Fix #201 - Add support for contextvars #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Weee, what a xmas gift! ❤️ I'm not sure if there's a better way nowadays, but you can use this approach from attrs. |
Merry Christmas 🎄 🙂
That's exactly what I was looking for, I think. |
|
Thanks, only fitting to merge it on Orthodox Christmas! ;) |
|
Thank you ❤️ ✨ |
hynek
added a commit
that referenced
this pull request
Jan 8, 2020
The two `context` in merge_context_local_context may look weird but they refer to two different contexts...
|
This was the only thing that stopped me from trying out structlog. Thank you both. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR basically turns #201 (comment) into something mergeable.
Open question: How do I cleverly exclude the
test_contextvars.pyfile on all Python 2 versions?