-
-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consistently name threadlocal and contextvars helper functions #238
Comments
The two `context` in merge_context_local_context may look weird but they refer to two different contexts...
Hmm that seems a little bit too repetitive and wordy. 🤔 Maybe the best way forward is to just drop the |
lol #239 |
Yeah I'm just gonna drop all the contexts unless someone wants to stop me. |
Sounds good to me 👍 |
The threadlocal and contextvars integrations use a different naming for their functions to bind, unbind, merge and clear the context. This came up as part of #236 and e3a6213.
I'd like to propose the following function names:
contextvars
merge_contextvars_context
clear_contextvars_context
bind_to_contextvars_context
unbind_from_contextvars_context
threadlocal
merge_threadlocal_context
clear_threadlocal_context
bind_to_threadlocal_context
unbind_from_threadlocal_context
-- doesn't exist but should probably be addedThe text was updated successfully, but these errors were encountered: