Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct MinMaxIdx function minIdx and maxIdx #1153

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from
Open

Correct MinMaxIdx function minIdx and maxIdx #1153

wants to merge 5 commits into from

Commits on Feb 26, 2024

  1. Changing return type of minIdx and maxIdx in MinMaxIdx to be a []int … 

    …rather than int. The return arrays will have input.dims elements. Adding test to confirm function is working with nD case.
    @HIGHER98
    HIGHER98 committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    9706924 View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2024

  1. Changing return type of minIdx and maxIdx in MinMaxIdx to be a []int … 

    …rather than int. The return arrays will have input.dims elements. Adding test to confirm function is working with nD case.
    @HIGHER98
    HIGHER98 committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    ee2e938 View commit details
    Browse the repository at this point in the history

  2. fix conflicts

    @HIGHER98
    HIGHER98 committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    65b5663 View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2024

  1. Adjusting TestMatMinMaxIdx3d function to create a zero'd 3d matrix. E… 

    …rrors were occuring before because of a non-zero'd mat being created. Malloc'ing space for min and max index in MinMaxIdx rather than making array and passing in address to [0] index.
    @HIGHER98
    HIGHER98 committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    c74a716 View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2024

  1. Removing specification of channels from matrix creation in test.

    @HIGHER98
    HIGHER98 committed Mar 3, 2024
    Configuration menu
    Copy the full SHA
    96d9869 View commit details
    Browse the repository at this point in the history