Correct MinMaxIdx function minIdx and maxIdx #1153
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #1151
This PR looks into changing return type of
minIdx
andmaxIdx
in theMinMaxIdx
function to be an[]int
rather thanint
, i.e.The return arrays will have input.dims elements.
Example:
In the above code snippet,
minVal
will be 0,maxVal
will be 17, minIdx will be[0,0]
, maxIdx will be[3,3]