Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete the current test suite #250

Merged
merged 3 commits into from
Jul 24, 2018

Conversation

theofidry
Copy link
Member

  • Add to the specs the registered classes and functions recorded via the keys 'registered-classes' and 'registered-functions'. This should not change the current behaviour but makes it easier to test this part of the whitelisting feature.
  • Add a check to ensure the keys used in 'meta' or a spec definition are all valid
  • Add the missing 'registered-functions' where appropriate
  • Moved the specs testing from PhpScoperTest to PhpScoperSpecTest to make it more readable
  • Do not record the functions return types (which can be identifiers or names as well)

@theofidry theofidry merged commit 1fd056d into humbug:master Jul 24, 2018
@theofidry theofidry deleted the feature/collection-lists branch July 24, 2018 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant