Complete the current test suite (#250)

- Add to the specs the registered classes and functions recorded via the keys `'registered-classes'` and `'registered-functions'`. This should not change the current behaviour but makes it easier to test this part of the whitelisting feature.
- Add a check to ensure the keys used in `'meta'` or a spec definition are all valid
- Add the missing `'registered-functions'` where appropriate
- Moved the specs testing from `PhpScoperTest` to `PhpScoperSpecTest` to make it more readable
- Do not record the functions return types (which can be identifiers or names as well)

specs/binary/simple.php

@@ -20,6 +20,8 @@
         'whitelist' => [],
         'whitelist-global-constants' => true,
         'whitelist-global-functions' => true,
+        'registered-classes' => [],
+        'registered-functions' => [],
     ],
 
     'Some statements made directly in the global namespace' => <<<'PHP'

specs/class-FQ.php

@@ -20,6 +20,8 @@
         'whitelist' => [],
         'whitelist-global-constants' => true,
         'whitelist-global-functions' => true,
+        'registered-classes' => [],
+        'registered-functions' => [],
     ],
 
     'Different kind of whitelisted class constant calls in the global scope' => [

specs/class-const/global-scope-single-level-with-single-level-use-statement-and-alias.php

@@ -20,6 +20,8 @@
         'whitelist' => [],
         'whitelist-global-constants' => true,
         'whitelist-global-functions' => true,
+        'registered-classes' => [],
+        'registered-functions' => [],
     ],
 
     'Constant call on a aliased class which is imported via an aliased use statement and which belongs to the global namespace' => [

specs/class-const/global-scope-single-level-with-single-level-use-statement.php

@@ -20,6 +20,8 @@
         'whitelist' => [],
         'whitelist-global-constants' => true,
         'whitelist-global-functions' => true,
+        'registered-classes' => [],
+        'registered-functions' => [],
     ],
 
     'Constant call on a class which is imported via a use statement and which belongs to the global namespace' => [

specs/class-const/global-scope-single-level.php

@@ -20,6 +20,8 @@
         'whitelist' => [],
         'whitelist-global-constants' => true,
         'whitelist-global-functions' => true,
+        'registered-classes' => [],
+        'registered-functions' => [],
     ],
 
     'Constant call on a class belonging to the global namespace' => [

specs/class-const/global-scope-two-level-with-single-level-use-and-alias.php

@@ -20,6 +20,8 @@
         'whitelist' => [],
         'whitelist-global-constants' => true,
         'whitelist-global-functions' => true,
+        'registered-classes' => [],
+        'registered-functions' => [],
     ],
 
     'Constant call on a namespaced class partially imported with an aliased use statement' => [

specs/class-const/global-scope-two-level-with-single-level-use.php

@@ -20,6 +20,8 @@
         'whitelist' => [],
         'whitelist-global-constants' => true,
         'whitelist-global-functions' => true,
+        'registered-classes' => [],
+        'registered-functions' => [],
     ],
 
     'Constant call on a namespaced class partially imported with a use statement' => [

specs/class-const/global-scope-two-level.php

@@ -20,6 +20,8 @@
         'whitelist' => [],
         'whitelist-global-constants' => true,
         'whitelist-global-functions' => true,
+        'registered-classes' => [],
+        'registered-functions' => [],
     ],
 
     'Constant call on a namespaced class' => [

specs/class-const/namespace-scope-single-level-with-single-level-use-statement-and-alias.php

@@ -20,6 +20,8 @@
         'whitelist' => [],
         'whitelist-global-constants' => true,
         'whitelist-global-functions' => true,
+        'registered-classes' => [],
+        'registered-functions' => [],
     ],
 
     'Constant call on a aliased class which is imported via an aliased use statement and which belongs to the global namespace' => [

specs/class-const/namespace-scope-single-level.php

@@ -20,6 +20,8 @@
         'whitelist' => [],
         'whitelist-global-constants' => true,
         'whitelist-global-functions' => true,
+        'registered-classes' => [],
+        'registered-functions' => [],
     ],
 
     'Constant call on a class belonging to the global namespace or the current namespace' => [

specs/class-const/namespace-scope-two-level-with-single-level-use-and-alias.php

@@ -20,6 +20,8 @@
         'whitelist' => [],
         'whitelist-global-constants' => true,
         'whitelist-global-functions' => true,
+        'registered-classes' => [],
+        'registered-functions' => [],
     ],
 
     'Constant call on a namespaced class partially imported with an aliased use statement' => [

specs/class-const/namespace-scope-two-level-with-single-level-use.php

@@ -20,6 +20,8 @@
         'whitelist' => [],
         'whitelist-global-constants' => true,
         'whitelist-global-functions' => true,
+        'registered-classes' => [],
+        'registered-functions' => [],
     ],
 
     'Constant call on a namespaced class partially imported with a use statement' => [

specs/class-const/namespace-scope-two-level.php

@@ -20,6 +20,8 @@
         'whitelist' => [],
         'whitelist-global-constants' => true,
         'whitelist-global-functions' => true,
+        'registered-classes' => [],
+        'registered-functions' => [],
     ],
 
     'Constant call on a namespaced class' => [

specs/class-const/namespace-single-part-with-single-level-use-statement.php

@@ -20,6 +20,8 @@
         'whitelist' => [],
         'whitelist-global-constants' => true,
         'whitelist-global-functions' => true,
+        'registered-classes' => [],
+        'registered-functions' => [],
     ],
 
     'Constant call on a class which is imported via a use statement and which belongs to the global namespace' => [

specs/class-static-prop/global-scope-single-level-with-single-level-use-statement-and-alias.php

@@ -20,6 +20,8 @@
         'whitelist' => [],
         'whitelist-global-constants' => true,
         'whitelist-global-functions' => true,
+        'registered-classes' => [],
+        'registered-functions' => [],
     ],
 
     'Constant call on a aliased class which is imported via an aliased use statement and which belongs to the global namespace' => <<<'PHP'

specs/class-static-prop/global-scope-single-level-with-single-level-use-statement.php

@@ -20,6 +20,8 @@
         'whitelist' => [],
         'whitelist-global-constants' => true,
         'whitelist-global-functions' => true,
+        'registered-classes' => [],
+        'registered-functions' => [],
     ],
 
     'Constant call on a class which is imported via a use statement and which belongs to the global namespace' => <<<'PHP'

specs/class-static-prop/global-scope-single-level.php

@@ -20,6 +20,8 @@
         'whitelist' => [],
         'whitelist-global-constants' => true,
         'whitelist-global-functions' => true,
+        'registered-classes' => [],
+        'registered-functions' => [],
     ],
 
     'Constant call on a class belonging to the global namespace' => <<<'PHP'

specs/class-static-prop/global-scope-two-level-with-single-level-use-and-alias.php

@@ -20,6 +20,8 @@
         'whitelist' => [],
         'whitelist-global-constants' => true,
         'whitelist-global-functions' => true,
+        'registered-classes' => [],
+        'registered-functions' => [],
     ],
 
     'Constant call on a namespaced class partially imported with an aliased use statement' => <<<'PHP'

specs/class-static-prop/global-scope-two-level-with-single-level-use.php

@@ -20,6 +20,8 @@
         'whitelist' => [],
         'whitelist-global-constants' => true,
         'whitelist-global-functions' => true,
+        'registered-classes' => [],
+        'registered-functions' => [],
     ],
 
     'Constant call on a namespaced class partially imported with a use statement' => <<<'PHP'

specs/class-static-prop/global-scope-two-level.php

@@ -20,6 +20,8 @@
         'whitelist' => [],
         'whitelist-global-constants' => true,
         'whitelist-global-functions' => true,
+        'registered-classes' => [],
+        'registered-functions' => [],
     ],
 
     'Constant call on a namespaced class' => <<<'PHP'

specs/class-static-prop/namespace-scope-single-level-with-single-level-use-statement-and-alias.php

@@ -20,6 +20,8 @@
         'whitelist' => [],
         'whitelist-global-constants' => true,
         'whitelist-global-functions' => true,
+        'registered-classes' => [],
+        'registered-functions' => [],
     ],
 
     'Constant call on a aliased class which is imported via an aliased use statement and which belongs to the global namespace' => <<<'PHP'

specs/class-static-prop/namespace-scope-single-level.php

@@ -20,6 +20,8 @@
         'whitelist' => [],
         'whitelist-global-constants' => true,
         'whitelist-global-functions' => true,
+        'registered-classes' => [],
+        'registered-functions' => [],
     ],
 
     'Constant call on a class belonging to the global namespace or the current namespace' => <<<'PHP'

specs/class-static-prop/namespace-scope-two-level-with-single-level-use-and-alias.php

@@ -20,6 +20,8 @@
         'whitelist' => [],
         'whitelist-global-constants' => true,
         'whitelist-global-functions' => true,
+        'registered-classes' => [],
+        'registered-functions' => [],
     ],
 
     'Constant call on a namespaced class partially imported with an aliased use statement' => <<<'PHP'

specs/class-static-prop/namespace-scope-two-level-with-single-level-use.php

@@ -20,6 +20,8 @@
         'whitelist' => [],
         'whitelist-global-constants' => true,
         'whitelist-global-functions' => true,
+        'registered-classes' => [],
+        'registered-functions' => [],
     ],
 
     'Constant call on a namespaced class partially imported with a use statement' => <<<'PHP'

specs/class-static-prop/namespace-scope-two-level.php

@@ -20,6 +20,8 @@
         'whitelist' => [],
         'whitelist-global-constants' => true,
         'whitelist-global-functions' => true,
+        'registered-classes' => [],
+        'registered-functions' => [],
     ],
 
     'Constant call on a namespaced class' => <<<'PHP'

specs/class-static-prop/namespace-single-part-with-single-level-use-statement.php

@@ -20,6 +20,8 @@
         'whitelist' => [],
         'whitelist-global-constants' => true,
         'whitelist-global-functions' => true,
+        'registered-classes' => [],
+        'registered-functions' => [],
     ],
 
     'Constant call on a class which is imported via a use statement and which belongs to the global namespace' => <<<'PHP'

specs/class/abstract.php

@@ -20,6 +20,8 @@
         'whitelist' => [],
         'whitelist-global-constants' => true,
         'whitelist-global-functions' => true,
+        'registered-classes' => [],
+        'registered-functions' => [],
     ],
 
     'Declaration in the global namespace' => <<<'PHP'

specs/class/anonymous.php

@@ -20,6 +20,8 @@
         'whitelist' => [],
         'whitelist-global-constants' => true,
         'whitelist-global-functions' => true,
+        'registered-classes' => [],
+        'registered-functions' => [],
     ],
 
     'Declaration in the global namespace' => <<<'PHP'

specs/class/conditional.php

@@ -20,6 +20,8 @@
         'whitelist' => [],
         'whitelist-global-constants' => true,
         'whitelist-global-functions' => true,
+        'registered-classes' => [],
+        'registered-functions' => [],
     ],
 
     'Declaration in the global namespace' => <<<'PHP'
@@ -62,9 +64,9 @@ class A
 }
 
 PHP
-    ,
+    ],
 
-    'Declaration in a namespace: prefix each namespace' => <<<'PHP'
+    'Declaration in a namespace' => <<<'PHP'
 <?php
 
 namespace Foo;
@@ -84,7 +86,7 @@ class A
 }
 
 PHP
-    ],
+    ,
 
     'Declaration of a whitelisted class' => [
         'whitelist' => ['Foo\A'],
@@ -108,7 +110,7 @@ class A
 }
 
 PHP
-        ],
+    ],
 
     'Multiple declarations in different namespaces' => <<<'PHP'
 <?php

specs/class/final.php

@@ -20,6 +20,8 @@
         'whitelist' => [],
         'whitelist-global-constants' => true,
         'whitelist-global-functions' => true,
+        'registered-classes' => [],
+        'registered-functions' => [],
     ],
 
     'Declaration in the global namespace' => <<<'PHP'

specs/class/interface.php

@@ -20,6 +20,8 @@
         'whitelist' => [],
         'whitelist-global-constants' => true,
         'whitelist-global-functions' => true,
+        'registered-classes' => [],
+        'registered-functions' => [],
     ],
 
     'Declaration in the global namespace' => <<<'PHP'

specs/class/regular-extend.php

@@ -20,6 +20,8 @@
         'whitelist' => [],
         'whitelist-global-constants' => true,
         'whitelist-global-functions' => true,
+        'registered-classes' => [],
+        'registered-functions' => [],
     ],
 
     'Declaration in the global namespace' => <<<'PHP'

specs/class/regular.php

@@ -20,6 +20,8 @@
         'whitelist' => [],
         'whitelist-global-constants' => true,
         'whitelist-global-functions' => true,
+        'registered-classes' => [],
+        'registered-functions' => [],
     ],
 
     'Declaration in the global namespace' => <<<'PHP'

specs/class/trait.php

@@ -20,6 +20,8 @@
         'whitelist' => [],
         'whitelist-global-constants' => true,
         'whitelist-global-functions' => true,
+        'registered-classes' => [],
+        'registered-functions' => [],
     ],
 
     'Declaration in the global namespace' => <<<'PHP'

specs/const/const-declaration-with-global-whitelisting.php

@@ -20,6 +20,8 @@
         'whitelist' => [],
         'whitelist-global-constants' => true,
         'whitelist-global-functions' => true,
+        'registered-classes' => [],
+        'registered-functions' => [],
     ],
 
     'Constants declaration in the global namespace' => [

specs/const/const-declaration.php

@@ -20,6 +20,8 @@
         'whitelist' => [],
         'whitelist-global-constants' => false,
         'whitelist-global-functions' => true,
+        'registered-classes' => [],
+        'registered-functions' => [],
     ],
 
     'Constants declaration in the global namespace' => [

specs/const/global-scope-global-with-global-whitelisting.php

@@ -20,6 +20,8 @@
         'whitelist' => [],
         'whitelist-global-constants' => true,
         'whitelist-global-functions' => true,
+        'registered-classes' => [],
+        'registered-functions' => [],
     ],
 
     'Constant call in the global namespace' => <<<'PHP'

specs/const/global-scope-global-with-single-level-use-statement-and-alias.php

@@ -20,6 +20,8 @@
         'whitelist' => [],
         'whitelist-global-constants' => false,
         'whitelist-global-functions' => true,
+        'registered-classes' => [],
+        'registered-functions' => [],
     ],
 
     'Constant call imported with an aliased use statement' => <<<'PHP'

specs/const/global-scope-global-with-single-level-use-statement-with-global-whitelisting.php

@@ -20,6 +20,8 @@
         'whitelist' => [],
         'whitelist-global-constants' => true,
         'whitelist-global-functions' => true,
+        'registered-classes' => [],
+        'registered-functions' => [],
     ],
 
     'Constant call imported with a use statement' => <<<'PHP'

specs/const/global-scope-global-with-single-level-use-statement.php

@@ -20,6 +20,8 @@
         'whitelist' => [],
         'whitelist-global-constants' => false,
         'whitelist-global-functions' => true,
+        'registered-classes' => [],
+        'registered-functions' => [],
     ],
 
     'Constant call imported with a use statement' => <<<'PHP'

specs/const/global-scope-global.php

@@ -20,6 +20,8 @@
         'whitelist' => [],
         'whitelist-global-constants' => false,
         'whitelist-global-functions' => true,
+        'registered-classes' => [],
+        'registered-functions' => [],
     ],
 
     'Constant call in the global namespace' => <<<'PHP'