Tests: fetch generation tests #34807
Draft
+29
−82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
This was referenced Nov 19, 2024
Merged
gante
commented
Nov 19, 2024
| @@ -1,56 +0,0 @@ | |||
| {% set name = "transformers" %} | |||
There was a problem hiding this comment.
this file is 4yr old and has very old requirements -- I'm assuming this was used in an older CI :D
gante
commented
Nov 19, 2024
| @@ -3138,7 +3138,7 @@ def test_logits_processor_not_inplace(self): | |||
| out = model.generate(input_ids, output_logits=True, output_scores=True, return_dict_in_generate=True) | |||
| out_with_temp = model.generate( | |||
| input_ids, | |||
| temperature=0.5, | |||
There was a problem hiding this comment.
(this change is to trigger the tests in this file)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP -- now that generation tests are being run, we can notice a few broken ones 👀
Generation tests that were not part of the model mixin tests were not being fetched. This PR fixes it, by allowing each job to apply multiple separate filters to then run the union of all filtered tests.
This PR:
👉 New files being fetched:
test_preparation/tests_generate_test_list.txt👉 dummy modification in a generation test triggering a test run:
(early commit before tests were fixed)