Fix Whisper CI #34617
Fix Whisper CI #34617
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
| else: # by default let's always generate 10 new tokens | ||
| generation_config.max_length = generation_config.max_length + input_ids_seq_length | ||
| if generation_config.max_length == GenerationConfig().max_length: | ||
| generation_config.max_length = generation_config.max_length + input_ids_seq_length | ||
| max_position_embeddings = getattr(self.config, "max_position_embeddings", None) | ||
| if max_position_embeddings is not None: | ||
| generation_config.max_length = min(generation_config.max_length, max_position_embeddings) |
There was a problem hiding this comment.
Diverge a bit from torch one, but let's try to match them in a follow-up when we feel it's time to do it.
Here is just to make CI green
it's flaky |
|
Should this be merged? |
Yes, but I am waiting for an approval. Currently, |
| if generation_config.max_length == GenerationConfig().max_length: | ||
| generation_config.max_length = generation_config.max_length + input_ids_length | ||
| max_position_embeddings = getattr(self.config, "max_position_embeddings", None) | ||
| if max_position_embeddings is not None: | ||
| generation_config.max_length = min(generation_config.max_length, max_position_embeddings) |
There was a problem hiding this comment.
thanks for putting this back!
|
Hey guys 👋 @ydshieh @ArthurZucker The generate changes in this PR are incorrect (changing If Whisper's tests are failing, then it is probably something wrong with either whisper or whisper's tests |
|
Hi @gante This PR is only adding
to avoid the failure caused in #34377 (which was an attempt fix for #34026)
Is the code changes in the previous PR #34377 (and/or #34026) are already wrong, or it's wrong because of the |
|
Yeah I think it's from the older pipeline PR 😭 ( |
|
But the check for |
|
So if we want to rollback, it's more involved (i.e. not revert this PR but some previous changes too). |
Finally CI is green