Offload fixes #17810
Merged
Offload fixes #17810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
| @@ -2449,6 +2451,15 @@ def _find_mismatched_keys( | |||
| gc.collect() | |||
|
|
|||
| if offload_index is not None and len(offload_index) > 0: | |||
| if model != model_to_load: | |||
| # We need to add the prefix of the base model | |||
There was a problem hiding this comment.
(nit) Maybe make the comment a bit more explicit? Took me a bit to figure out what is going on here
Suggested change
| # We need to add the prefix of the base model | |
| # We need to add the prefix of the base model `model_to_load` to be able to correctly the weights into the task model `model` |
patrickvonplaten
approved these changes
Jun 21, 2022
younesbelkada
pushed a commit
to younesbelkada/transformers
that referenced
this pull request
Jun 25, 2022
* Offload fixes * Add a test
younesbelkada
pushed a commit
to younesbelkada/transformers
that referenced
this pull request
Jun 29, 2022
* Offload fixes * Add a test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes a few bugs in the current offload to disk implementation via Accelerate.
offload_folderis not created if it doesn't exists, loading to cryptic errors about missing files.offload_state_dict=True, the weights should be reloaded inmodel_to_loadfrom the temporary offloadbase_model_clsprefix since they were offloaded as weights ofmodel_to_loadand not ofmodel.