Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Offload fixes #17810

Merged
merged 2 commits into from
Jun 22, 2022
Merged

Offload fixes #17810

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5318cf8
Offload fixes
sgugger Jun 21, 2022
5ead4bf
Add a test
sgugger Jun 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 16 additions & 5 deletions src/transformers/modeling_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2271,11 +2271,13 @@ def _load_pretrained_model(
offload_state_dict=False,
dtype=None,
):
if device_map is not None and "disk" in device_map.values() and offload_folder is None:
raise ValueError(
"The current `device_map` had weights offloaded to the disk. Please provide an `offload_folder` for"
" them."
)
if device_map is not None and "disk" in device_map.values():
if offload_folder is None:
raise ValueError(
"The current `device_map` had weights offloaded to the disk. Please provide an `offload_folder`"
" for them."
)
os.makedirs(offload_folder, exist_ok=True)
# Retrieve missing & unexpected_keys
model_state_dict = model.state_dict()
expected_keys = list(model_state_dict.keys())
Expand Down Expand Up @@ -2449,6 +2451,15 @@ def _find_mismatched_keys(
gc.collect()

if offload_index is not None and len(offload_index) > 0:
if model != model_to_load:
# We need to add the prefix of the base model
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(nit) Maybe make the comment a bit more explicit? Took me a bit to figure out what is going on here

Suggested change
# We need to add the prefix of the base model
# We need to add the prefix of the base model `model_to_load` to be able to correctly the weights into the task model `model`

prefix = cls.base_model_prefix
for weight_name in offload_index:
shutil.move(
os.path.join(offload_folder, f"{weight_name}.dat"),
os.path.join(offload_folder, f"{prefix}.{weight_name}.dat"),
)
offload_index = {f"{prefix}.{key}": value for key, value in offload_index.items()}
save_offload_index(offload_index, offload_folder)

if offload_state_dict:
Expand Down