Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[test] split test into 4 sub-tests to avoid timeout #12710

Merged
merged 2 commits into from
Jul 14, 2021
Merged

[test] split test into 4 sub-tests to avoid timeout #12710

merged 2 commits into from
Jul 14, 2021

Conversation

stas00
Copy link
Contributor

@stas00 stas00 commented Jul 14, 2021 •
edited
Loading

This PR splits the long test into 4 sub-tests to avoid timeout, as each sub-test is relatively slow.

This supercedes #12699

@LysandreJik, @sgugger

@stas00 stas00 mentioned this pull request Jul 14, 2021
Closed
sgugger
sgugger approved these changes Jul 14, 2021
View reviewed changes
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smart way to split it, LGTM!

@stas00 stas00 merged commit a18a17d into huggingface:master Jul 14, 2021
@stas00 stas00 deleted the slow-replicate-test branch July 14, 2021 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgugger sgugger sgugger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stas00 @sgugger