-
Notifications
You must be signed in to change notification settings - Fork 27.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a custom timeout for log replica test #12699
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed on trying to keep those to a minimum.
Hmm, it's really slow - clocked Let me see first if it can be made faster. |
It's like 4 tests in one - so it adds up - I guess I could just split it in several sub-tests. |
What do you guys prefer here? We can also make it @slow - which will shave off ~80sec - it doesn't need to run all the time at all. |
No strong opinion on my side, do what you think is best! |
oh, but these are multi-gpu tests so they are @slow already as they only run on our machine only @LysandreJik, does this impact the push workflow? or just scheduled one? If so I'd also |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But the review is that it should not timeout. As it's 4 tests in one.
Let's decide how to change the test so that it is not an outlier.
Here we go: #12710 - reworked 1 to 4 subtests, shouldn't run longer than the timeout now. |
merged the alternative solution, closing this then |
The multi GPU tests are run every time there is a commit on Thanks a lot for splitting that test, way better solution. |
ok, so should we put fairscale and apex tests to @slow then? These are hardly ever used by anyone, so would be a waste to spend $$ and time on those. |
We can, but it's not a super high priority, they seem to run quickly enough |
Add a custom timeout for log replica test. Let's keep these outliers to a minimum.