Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: bnb config wrong argument names #1603

Merged
merged 2 commits into from
Apr 5, 2024
Merged

FIX: bnb config wrong argument names #1603

merged 2 commits into from
Apr 5, 2024

Commits on Mar 28, 2024

  1. FIX Incorrect argument name in BitsAndBytesConfig 

    Several tests were using bnb_4bit_compute_type but the argument should
be called bnb_4bit_compute_dtype. Now the correct name is used.

This change should not affect the tests, because they were passing the
default value anyway. Therefore, the fact that this argument was passed
incorrectly (and thus, presumably, ignored) should not affect the
results.

It is a bit unfortunate that this sort of typo passes completely silently.
    @BenjaminBossan
    BenjaminBossan committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    16c632d View commit details
    Browse the repository at this point in the history

  2. Fix another incorrect argument to bnb config 

    These were caused by an incorrect search and replace operation in huggingface#1552.
    @BenjaminBossan
    BenjaminBossan committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    3da867f View commit details
    Browse the repository at this point in the history