FIX: bnb config wrong argument names #1603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Several tests were using bnb_4bit_compute_type but the argument should be called bnb_4bit_compute_dtype. Now the correct name is used. This change should not affect the tests, because they were passing the default value anyway. Therefore, the fact that this argument was passed incorrectly (and thus, presumably, ignored) should not affect the results. It is a bit unfortunate that this sort of typo passes completely silently.
These were caused by an incorrect search and replace operation in huggingface#1552.
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
younesbelkada
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several tests were using
bnb_4bit_compute_typebut the argument should be calledbnb_4bit_compute_dtype. Now thecorrect name is used.
This change should not affect the tests, because they were passing the default value anyway. Therefore, the fact that this argument was passed incorrectly (and thus, presumably, ignored) should not affect the results.
Also, in some tests
quantization_config=BitsAndBytesConfig(load_in_4bit=True)was passed as argument toBitsAndBytesConfigdue to an overeager search and replace in #1552. Fixing those changes the test outcome but locally they still passed for me.It is a bit unfortunate that this sort of typo passes completely silently.