Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #25 (and #24).
So it turns out that if num != 'full' then the AFB was not subtracted from the test data even if AFB=True which would mess with the early stopping. Fortunately, if num=`full' (i.e. all the training data is used in training) the AFB was subtracted from the test data. Hopefully nobody was doing production runs with num != 'full'.
Also noticed that the test data was not being divided by the standard deviation of the training data but instead by the standard deviation of the test data. Rookie error. Probably will have had a detrimental effect on the early stopping (in v1.7.0 and above I think). However, I think it would be minor, as we would expect the standard deviation of the test data and training data to be approximately equivalent if the test data is representative.
These errors will have only effected the early stopping algorithm that was introduced in #15. It will not have had any impact on the post-processing of predictions from the network and therefore will not have had a negative impact on the calculation of RMSEs for test data or other asessments of accuracy for example.
We can see this working properly now for training data
and test data
Took the oportunity to change the default logging of input parameters as well.