Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test preprocessing #26

Merged
merged 4 commits into from
Jan 16, 2024
Merged

Test preprocessing #26

merged 4 commits into from
Jan 16, 2024

Conversation

htjb
Copy link
Owner

@htjb htjb commented Jan 16, 2024

Solves #25 (and #24).

So it turns out that if num != 'full' then the AFB was not subtracted from the test data even if AFB=True which would mess with the early stopping. Fortunately, if num=`full' (i.e. all the training data is used in training) the AFB was subtracted from the test data. Hopefully nobody was doing production runs with num != 'full'.

Also noticed that the test data was not being divided by the standard deviation of the training data but instead by the standard deviation of the test data. Rookie error. Probably will have had a detrimental effect on the early stopping (in v1.7.0 and above I think). However, I think it would be minor, as we would expect the standard deviation of the test data and training data to be approximately equivalent if the test data is representative.

These errors will have only effected the early stopping algorithm that was introduced in #15. It will not have had any impact on the post-processing of predictions from the network and therefore will not have had a negative impact on the calculation of RMSEs for test data or other asessments of accuracy for example.

We can see this working properly now for training data

train_example_processed_figures

and test data

test_example_processed_figures

Took the oportunity to change the default logging of input parameters as well.

@htjb
Copy link
Owner Author

htjb commented Jan 16, 2024

Note that in the attached graphs the scale is different when resampling is performed since the standard deviation is calcualted after resampling.

@htjb htjb merged commit bbe7934 into master Jan 16, 2024
11 of 12 checks passed
@htjb htjb deleted the test_preprocessing branch January 16, 2024 16:23
This was referenced Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant