Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Data Preprocessing #25

Closed
htjb opened this issue Jan 16, 2024 · 1 comment
Closed

Test Data Preprocessing #25

htjb opened this issue Jan 16, 2024 · 1 comment

Comments

@htjb
Copy link
Owner

htjb commented Jan 16, 2024

I currently think that the preprocessing for the test data is not right and this will impact the early stopping. Below is an example of the preprocessed training data with various combinations of AFB and resampling on (division by the standard deviation of the training data is on by default here)

train_example_processed_figures

and the same for the test data

test_example_processed_figures

Clearly something is not right here. It looks like the AFB subtraction is never applied to the test data.

Will open a PR to debug and fix.

@htjb htjb mentioned this issue Jan 16, 2024
@htjb
Copy link
Owner Author

htjb commented Jan 16, 2024

Closed with #26.

@htjb htjb closed this as completed Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant