Add heuristic for memory->framebuffer copies, fixing video flicker in Naruto UNH 2 #18008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrydgard
added a commit
that referenced
this pull request
Sep 12, 2023
Revert "Merge pull request #18008 from hrydgard/naruto-video-flicker-heuristic"
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17740
The game makes a copy of video data that we detect as being to a left-behind 16-bit framebuffer, overlapping the intended target. This makes a heuristic check for old framebuffers that are too small, and decides that it's probably not the right target.
Alternatively, we should simply copy to all overlapping buffers...
Actually, thinking of adding scoring here like in other cases of framebuffer matching, which would reduce the potential fallout in case some game accidentally relies on the old behavior. Might do that before merge.Done.