-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Libretro] Update core options to v2 + add a few new ones #16319
Conversation
Hi guys, for further clarification, it seemed libretro cores stopped building after this PR was merged - Could that possibly be looked into? Thanks. |
@LibretroAdmin sure. Weird one though... Would have expected that we had enough uses of libzip already, that some extended use wouldn't have a risk of causing linker errors.. |
See #16322. I'm still not interested enough in libretro to test it or figure out how to compile it, obviously the Actions build that someone contributed isn't telling us anything. Actions is saying to use -[Unknown] |
Thank you for the build fix, building just fine now! 👍 |
Looks fine to me for whatever it's worth. |
Still some build errors though, as unknown says, please replace
with
And maybe a rebase on master + force-push for good measure. |
Oh sorry, completely missed it, let's try again! edit: Ah crap, another one in libretro_core_options_intl.h too it seems -_- Sorry again... |
Updated core options to v2 + added the following options: "Cache Full ISO in RAM", "PSP Model" and "Hardware Tesselation".
Updated core options to v2 (so we can have categories and descriptions) + added the following options: "Cache Full ISO in RAM", "PSP Model" and "Hardware Tesselation". A review would be welcome! Still learning C/C++ and not used to big PRs like this, so please be gentle! 😳
For now I only made 3 categories: "System", "Video" and "Network":
Still better than having everything mixed IMO. Only put a few descriptions (grabbed from standalone), feel free to add more, I kinda suck at writing in English and I also don't even know what some of these options do, so... :p
P.S: the "PSP Model" option should fix #15306, this is what I get with the core option set to "PSP-1000":
and when set to "PSP-2000/3000":
Also, Libretro builds seem to be broken currently for Windows and OSX because of a few
unresolved external symbol zip_XXXX referenced
: https://git.libretro.com/libretro/ppsspp/-/jobs/2706096