Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Libretro] Update core options to v2 + add a few new ones #16319

Merged
merged 1 commit into from
Nov 2, 2022

Conversation

bslenul
Copy link
Contributor

@bslenul bslenul commented Nov 1, 2022

Updated core options to v2 (so we can have categories and descriptions) + added the following options: "Cache Full ISO in RAM", "PSP Model" and "Hardware Tesselation". A review would be welcome! Still learning C/C++ and not used to big PRs like this, so please be gentle! 😳

For now I only made 3 categories: "System", "Video" and "Network":

image

Still better than having everything mixed IMO. Only put a few descriptions (grabbed from standalone), feel free to add more, I kinda suck at writing in English and I also don't even know what some of these options do, so... :p

P.S: the "PSP Model" option should fix #15306, this is what I get with the core option set to "PSP-1000":

1000

and when set to "PSP-2000/3000":

2000

Also, Libretro builds seem to be broken currently for Windows and OSX because of a few unresolved external symbol zip_XXXX referenced: https://git.libretro.com/libretro/ppsspp/-/jobs/2706096

@LibretroAdmin
Copy link

Hi guys, for further clarification, it seemed libretro cores stopped building after this PR was merged -
https://git.libretro.com/libretro/ppsspp/-/commit/3f33cf102c7b33e4c53d3ad9c73c0f0e0aa58a59

Could that possibly be looked into? Thanks.

@hrydgard
Copy link
Owner

hrydgard commented Nov 1, 2022

@LibretroAdmin sure. Weird one though... Would have expected that we had enough uses of libzip already, that some extended use wouldn't have a risk of causing linker errors..

@unknownbrackets
Copy link
Collaborator

See #16322. I'm still not interested enough in libretro to test it or figure out how to compile it, obviously the Actions build that someone contributed isn't telling us anything.

Actions is saying to use #include "libretro.h", which it seems other files like libretro_vulkan.h already do.

-[Unknown]

@bslenul
Copy link
Contributor Author

bslenul commented Nov 2, 2022

Thank you for the build fix, building just fine now! 👍

@LibretroAdmin
Copy link

Looks fine to me for whatever it's worth.

@hrydgard
Copy link
Owner

hrydgard commented Nov 2, 2022

Still some build errors though, as unknown says, please replace

#include <libretro.h>

with

#include "libretro.h" or with a more detailed path if appropriate.

And maybe a rebase on master + force-push for good measure.

@bslenul
Copy link
Contributor Author

bslenul commented Nov 2, 2022

Oh sorry, completely missed it, let's try again!

edit: Ah crap, another one in libretro_core_options_intl.h too it seems -_- Sorry again...

Updated core options to v2 + added the following options: "Cache Full ISO in RAM", "PSP Model" and "Hardware Tesselation".
@hrydgard hrydgard merged commit 74ac903 into hrydgard:master Nov 2, 2022
@bslenul bslenul deleted the core-opts-v2 branch November 2, 2022 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot set PSP Model on RetroArch, Toukiden does not work properly~!
4 participants