Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Framebuffer fetch fixes #13646

Merged
merged 3 commits into from
Nov 9, 2020
Merged

Framebuffer fetch fixes #13646

merged 3 commits into from
Nov 9, 2020

Conversation

hrydgard
Copy link
Owner

@hrydgard hrydgard commented Nov 9, 2020

Fix issue with EXT_shader_framebuffer_fetch on OpenGL ES 3.0.

Remove support for NV_shader_framebuffer_fetch, extremely rare and old.

Should help with the error seen in #13639 .

Copy link
Contributor

@Panderner Panderner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it break any games that uses NV_shader_framebuffer_fetch?

@hrydgard
Copy link
Owner Author

hrydgard commented Nov 9, 2020

NV_framebuffer_fetch is an extension a device can expose for PPSSPP and other apps to use. For PPSSPP it's just an optimization, and the only device I'm aware of that exposes it is the very old NVIDIA Shield handheld.

@hrydgard hrydgard merged commit 9f33a82 into master Nov 9, 2020
@hrydgard hrydgard deleted the framebuffer-fetch-fixes branch November 9, 2020 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GE emulation Backend-independent GPU issues OpenGL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants