Thrillville Off The Rails Graphics' issues

[GuilhermeGS2]

Hey devs, I'm here to report an issue, my game Thrillville Off The Rails isn't playable anymore since v0.9.8-1268-g2a3626d, that was the last build which the game is playable. I reported it in the game thread, but I think hardly some dev will read, so I'm creating a new one. The alteration made after v0.9.8-1268-g2a3626d is:

Merge: 2a3626d 19f35bbMerge pull request #6362 from unknownbrackets/gpu-minorUpload stencil/color on FBO create, clear depth/stencil to 0, fix software transform

This problem began with v0.9.8-1275-g413704f and is here till today. So if you guys could fix this game, would make me glad. Maybe this fix some other games as well.

How it's:

http://i58.tinypic.com/2ev88br.png

How it should be:

http://i57.tinypic.com/2h3ojkp.png

[GuilhermeGS2]

Can somebody reply at least?

[Margen67]

This still happens as of 22cef33 and in the original/first game as well.

[GuilhermeGB19]

So, what about this? Someone interested in work on this?

There's another issue too, when the game was working, it worked only when buffer rendering was disabled, because we have graphics issue with buffer rendering.

Buffer rendering on:

http://imgur.com/ElvwdmG

Buffer rendering off:

http://imgur.com/cH9oR4a

And this is how it looks after v0.9.8-1268:

http://imgur.com/AznYrbL

[GuilhermeGS2]

Looks like you devs are focusing in graphic issue, so could you take a look at this one? Tell something you need and I'll provide. This game brings me nostalgia from my childhood, it would be nice to play on PPSSPP.

I used GE debugger and the Step Draw button, I noticed only few first drawings are shown, the HUD and the logo are the only last drawings that are executed. In v0.9.8-1268 when the graphics were good, this issues already was present in Software Rendering.

[hrydgard]

Oh yeah, forgot about this one. It's failing to clear, and suddenly I understand why:

@unknownbrackets I guess we better try to test and implement that suspected immediate draw stuff...

[hrydgard]

pretty clear that f0, f1, f2 are x, y, z. Z looks fine for a clear, but X and Y are a bit odd. They're symmetrical - the first X is 0x8000-0xF00 and the second X is 0x8000+0xF00. Same with Y, 0x8000-0x880 and 0x8000+0x880.

0xF00 / 16 = 240 which is the half the width and 0x880 / 16 = 136 which is the correct half-height so these seem to be raw subpixel coordinates before the "offset". Subtracting the offsets before the division by 16 gives correct coordinates.

As for f6 and f7... f6 is probably the color, black. f7? 6ff and 7ff, very odd. begin/end? Actually the 6 is probably RECT and 7 the marker to end the primitive. ff would be the alpha of the color.

EDIT: I've implemented converting and collecting the vertices, but injecting them at the right point in the pipeline is gonna take some refactoring.

[GuilhermeGS2]

Thank you for taking a look at this. Tell if can help with something.

[hrydgard]

Fixed now.

[GuilhermeGS2]

The issue hasn't been fixed yet. :/

[hrydgard]

What? Are you sure you're trying the latest build? Which region of the game?

[GuilhermeGS2]

Thrillville and Thrillville Off The Rails are different games, I just tested the original and really is working, but the second game is still the same. And one more thing, it's woking on Windows only, not on Android.

[hrydgard]

Aha, I might have found the problem. Any skipped frame will break the code that fixes this, like unthrottle or any frameskip setting... Fixing that.

[hrydgard]

@GuilhermeGS2 new build is up.

[GuilhermeGS2]

Finally, it's working. Thank you very much! :D