Add Docker support

[ClFeSc]

Closes #117

Supersedes #144

What did we change in this PR?

• You can now start the whole app with docker-compose up -d in the root directory. See README.md for more details.
• We fixed some issues that surfaced while doing this, like the incorrect start:once for the backend.

From #117:

• pass environment flags (whether production or not) to immer, socket.io, etc. (or make sure they use the Node environment)

[ClFeSc]

Regarding production flags:

Backend

• class-validator: No production setting
• cors: No production setting
• dotenv: No production setting
• envalid: Should use NODE_ENV. Set to production mode when NODE_ENV=production
• express: Should use NODE_ENVSet to production when NODE_ENV=production
• lodah-es: No production setting
• socket.io: Not sure whether socket.io itself uses production environment, but if it does it takes its information from NODE_ENV with NODE_ENV=production
• supertest: Accidently a dependency, should be a devDependency...

Frontend

• Everything angular: I think we are safe by using --configuration deployment (that is identical to production apart from the ports) and ng build that should use productionby default.
• @ngrx/store: Should have a production mode but I couldn't find a way to enable it. Probably relies on other environments such as angular.
• bootstrap : No production setting
• lodash-es: No production setting
• ol: Production enabled when building the app
• rxjs: No production setting
• socket.io-client: No production setting
• tslib: No production setting
• zone.js: No production setting

Shared

• class-transformer: No production setting
• class-validator: No production setting
• immer: Appears to be using NODE_ENV' with NODE_ENV=production`
• lodash-es: No production setting
• reflect-metadata: No production setting
• uuid: No production setting

Root

No dependencies

Method

I looked through all dependencies of our four package.jsons. It doesn't seem to be necessary to do anything as far as I can tell.

[ClFeSc]

In my opinion, we should handle deployment in another issue/PR as it is not 100% tied to the dockerization. What are your thoughts on that?

[Dassderdie]

• immer: Appears to be using NODE_ENv' with NODE_ENV=production`

Immer is also used in the frontend (because it is in shared).

I found this workaround to make it run in production in the frontend too:
immerjs/immer#557 (comment)

[Dassderdie]

In my opinion, we should handle deployment in another issue/PR as it is not 100% tied to the dockerization. What are your thoughts on that?

Sure.

[ClFeSc]

• immer: Appears to be using NODE_ENv' with NODE_ENV=production`

Immer is also used in the frontend (because it is in shared).

I found this workaround to make it run in production in the frontend too: immerjs/immer#557 (comment)

Ah, right. I completely forgot the frontend is no node app... I think this approach should be possible without issues. What would be the best place to add this snippet? There is not really an index.ts, right?

[Dassderdie]

• immer: Appears to be using NODE_ENv' with NODE_ENV=production`

Immer is also used in the frontend (because it is in shared).
I found this workaround to make it run in production in the frontend too: immerjs/immer#557 (comment)

Ah, right. I completely forgot the frontend is no node app... I think this approach should be possible without issues. What would be the best place to add this snippet? There is not really an index.ts, right?

frontend\src\main.ts is the place to add it. - (Don't forget to comment why we are doing this)

[ClFeSc]

I have no clue why this fails. VSCode tells me window.process should be of type NodeJS.Process.

[Dassderdie]

I have no clue why this fails. VSCode tells me window.process should be of type NodeJS.Process.

We don't have the node typings in the frontend, but vscode doesn't get that. I would just use as any a lot...

[ClFeSc]

I have no clue why this fails. VSCode tells me window.process should be of type NodeJS.Process.

We don't have the node typings in the frontend, but vscode doesn't get that. I would just use as any a lot...

Ah, I see. Fixed it by adding some as anys.

[ClFeSc]

@Dassderdie Your issue should be fixed and this PR should be ready for review.

[Dassderdie]

I still get the same error with cannot read env of undefined (probably because of docker-compose reusing some not invalidated cache?).
I set a breakpoint on main.js and manually added window.process = {} and it worked. So if it works for you it's good to go.

[ClFeSc]

You can do something like docker volume ls. Copy the volume name containing frontend and run docker volume rm <this copied name>. Then run docker-compose down and docker-compose up -d --build. This should fix it.

[Dassderdie]

You can do something like docker volume ls. Copy the volume name containing frontend and run docker volume rm <this copied name>. Then run docker-compose down and docker-compose up -d --build. This should fix it.

worked 👍