Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicated .gitignore entries #36

Closed
Dassderdie opened this issue Jan 8, 2022 · 3 comments · Fixed by #50
Closed

Duplicated .gitignore entries #36

Dassderdie opened this issue Jan 8, 2022 · 3 comments · Fixed by #50
Labels
meta Issues mainly related to non-TS stuff (e.g. CI) wontfix This will not be worked on

Comments

@Dassderdie
Copy link
Collaborator

We currently pass the root .gitignore as the ignore file for prettier.

Prettier doesn't respect nested .gitignore files.

My proposal: we merge all our .gitignore files into the root file.
@Dassderdie Dassderdie mentioned this issue Jan 9, 2022
Merged
@Dassderdie Dassderdie mentioned this issue Jan 14, 2022
Merged
@Dassderdie Dassderdie linked a pull request Jan 14, 2022 that will close this issue
Hotfix/36 cleanup gitignore files #50
Merged
@ClFeSc
Copy link
Contributor

ClFeSc commented Jan 15, 2022

We should make sure to use a common style regarding /dist vs dist.

@ClFeSc ClFeSc added the meta Issues mainly related to non-TS stuff (e.g. CI) label Jan 29, 2022
@ClFeSc
Copy link
Contributor

ClFeSc commented Feb 12, 2022

In #172 we introduced a .dockerignore file. As Docker only supports one of these files in the root of the workdir, we had to create on for all subfolders. Maybe we should do this as well for the .gitignore that we just only have the file in the root folder, and no more? We can structure this file like # Root, # Frontend, etc.

@Dassderdie
Copy link
Collaborator Author

The problem with this is, that eslint must be run separately on the frontend, backend, and shared and needs a .gitignore too (see the lint scripts)...

So I don't think we can get this working without at least partial duplication of the .gitignores...

@Dassderdie Dassderdie changed the title Prettier doesn't respect nested .gitignore files Duplicated .gitignore entries Mar 15, 2022
@Dassderdie Dassderdie added the wontfix This will not be worked on label Mar 15, 2022
@ClFeSc ClFeSc closed this as not planned Won't fix, can't repro, duplicate, stale Jul 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
meta Issues mainly related to non-TS stuff (e.g. CI) wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Hotfix/36 cleanup gitignore files hpi-sam/digital-fuesim-manv
2 participants
@Dassderdie @ClFeSc