Remove target children with duplicate ID before append/prepend #240
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #132
@dhh this implements Option C of #132 (comment)
When appending/prepending, children of the template may contain the same ID as children of the existing target.
(this is common when using turbo-rails or other frameworks where the append/prepend action comes both as a result of the response to the original action and as a broadcasted action from a background job).
When this is the case, the generated result contains duplicate children ID which is undesirable.
This PR changes the behaviour of the append/prepend actions so that the existing children of the target which match the children of the template are removed before appending the template.
Assuming the following contrived example:
Target:
Stream element:
With the current code, the result is:
This PR changes it so the result is