-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade UI #29
Merged
Merged
Upgrade UI #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR focuses on making big improvements related to the User Interface (UI) & the User Experience (UX). I have mentioned most of it here.
Navigation bar stylings:
Before
After
Create Sabeel
.Search stylings:
Before
After
Turbo Stream Layout:
Before
After
button_to
with thelink_to
tag for all the requests that areget
type.Sabeel show layout:
Before
After
Thaali show layout:
Before
After
balance
&paid
values outside the context ofthaali
.Transaction show layout:
Before
After
Packages & Gems:
bootstrap
package tov5.3.2
.font-awesome
package tov6.4.2
.stimulus
package tov3.2.2
.esbuild
package tov0.16.7
.sass
package tov1.69.5
.turbo-rails
gem tov1.5.0
.turbo-rails
package tov7.3.0
.bootstrap-icon
package.Base Stylings:
Nunito
&Josefins
fonts for font styles.Form Stylings:
*
(required) tick from the label fields.Misc
contact
layout and render it in the navbar.back
,note
, &about
layout.thaali
column from the transaction table.🥳 Bug Fix
Show link inside turbo streams are making requests twice
Upgrading the
turbo-rails
package & gem introduced a new bug in turbo_stream pages. After redirecting to ashow
page from a turbo_stream page and then clicking the browser back button, it showed the same content twice. Hence, rendering duplicate content.I found this PR addressing this issue and fixed the bug in this commit.