Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade UI #29

Merged
merged 167 commits into from
Dec 9, 2023
Merged

Upgrade UI #29

merged 167 commits into from
Dec 9, 2023

Conversation

JuzerShakir
Copy link
Owner

@JuzerShakir JuzerShakir commented Dec 1, 2023

This PR focuses on making big improvements related to the User Interface (UI) & the User Experience (UX). I have mentioned most of it here.

Navigation bar stylings:

Before

Screenshot from 2023-12-02 03-25-50

After

  • Show an FMB logo instead of the 'FMB' text in the navbar.
  • New button styles for Create Sabeel.
  • Show the navbar to a logged-out user with different content.

Screenshot from 2023-12-02 03-31-09

Search stylings:

Before

Screenshot from 2023-12-02 03-32-51

After

  • Added an animation when you hover on the search bar.

Screenshot from 2023-12-02 03-33-03

Turbo Stream Layout:

Before

Screenshot from 2023-12-02 03-36-18

After

  • Remove extra padding in each record to fit more content in the viewport.
  • Change the color scheme to match the theme.
  • Replace button_to with the link_to tag for all the requests that are get type.

Screenshot from 2023-12-02 03-36-41

Sabeel show layout:

Before

sabeel-before

After

  • Clicking on the phone number will open your default call app to make a local call to him/her.
  • Clicking on the email address will open your default email app to send an e-mail to him/her.

Screenshot from 2023-12-02 10-33-15

Thaali show layout:

Before

Screenshot from 2023-12-02 10-48-57

After

  • Showing balance & paid values outside the context of thaali.

Screenshot from 2023-12-02 10-49-05

Screenshot from 2023-12-02 10-53-12

Transaction show layout:

Before

trans-before

After

Screenshot from 2023-12-02 11-07-46


Packages & Gems:

  • Upgrade the bootstrap package to v5.3.2.
  • Upgrade the font-awesome package to v6.4.2.
  • Upgrade the stimulus package to v3.2.2.
  • Upgrade the esbuild package to v0.16.7.
  • Upgrade the sass package to v1.69.5.
  • Upgrade the turbo-rails gem to v1.5.0.
  • Upgrade the turbo-rails package to v7.3.0.
  • Remove the bootstrap-icon package.

Base Stylings:

  • Use a 7-1 pattern for manageable CSS
  • Using Nunito & Josefins fonts for font styles.
  • Use a custom theme to have a consistent color scheme across the site.
  • Update bootstrap variables with a new theme color palette.
  • Replace custom CSS stylings with bootstrap.
  • Leverage SASS for refactoring.
  • Reorder all the classes alphabetically.

Form Stylings:

  • Update bootstraps' default form stylings via its variables.
  • Show the first validation error message instead of showing all of them for each attribute.
  • Use the horizontal form layout for large devices.
  • Remove the * (required) tick from the label fields.

Misc

  • Add animation to flash messages.
  • Disable text selection.
  • Update the view of the contact layout and render it in the navbar.
  • Remove the back, note, & about layout.
  • Remove the thaali column from the transaction table.

🥳 Bug Fix

  1. Show link inside turbo streams are making requests twice

  2. Upgrading the turbo-rails package & gem introduced a new bug in turbo_stream pages. After redirecting to a show page from a turbo_stream page and then clicking the browser back button, it showed the same content twice. Hence, rendering duplicate content.

Screenshot from 2023-12-02 11-59-54

I found this PR addressing this issue and fixed the bug in this commit.

@JuzerShakir JuzerShakir marked this pull request as ready for review December 9, 2023 11:36
@JuzerShakir JuzerShakir merged commit ebdf666 into master Dec 9, 2023
1 check passed
@JuzerShakir JuzerShakir deleted the upgrade-ui branch January 30, 2024 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant