Improving issue #574 implementation. #674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This improves the implementation of issue hotsh#574 (twitter-compatible API: /statuses/show/:id.json ), including support for the trim_user option. Removed json_api/statuses_test and included tests in api/twitter_api_test, which already contained tests to the Twitter-API features. Signed-off-by: DiogoAndre <[email protected]>
wilkie
added a commit
that referenced
this pull request
Oct 5, 2012
Improving issue #574 implementation.
|
Hey @DiogoAndre, since this was merged in I'm going to add you to the team of committers-- this means you can push directly to the twitter-api branch if you want (since we'll be doing a big code review before it gets merged into master). Please read the section in the readme about being a committer too and let me know if you have any questions ❤️ ❤️ I should also have you up on the About page in a few minutes! I'm excited to have you on the team, and I hope to be seeing more contributions from you!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the implementation of issue #574 (twitter-compatible API: /statuses/show/:id.json ), including support for the trim_user option.
Removed json_api/statuses_test and included tests in api/twitter_api_test, which already contained tests to the Twitter-API features.