show status implementation #662
Conversation
…art without and see.
An incomplete implementation, but provides most of the important stuff that would be needed to pull a home timeline from a third party client. Seems to work well enough to be useful. [hotsh#570]
Similar to home_timeline and user_timeline looks like it might be good to extract out preparing the json this commit should satisfy hotsh#572
Twiter-api GET /api/statuses/mention.json
simple start for hotsh#603 that will give a basic acceptance test that the api calls return valid JSON
- acceptance testing for the api methods that have already been implemented. - cleaned up require_relative backport to 1.8 line
603 testing
user needs to be an instance variable Signed-off-by: DiogoAndre <[email protected]>
ref issue 574 Signed-off-by: DiogoAndre <[email protected]>
|
You may want to remove that last commit and rebase with master as the travis issue was fixed there as well. |
|
Removed that last commit. Shouldn't we instead merge master into twitter-api? I think it's is a better way of bringing the twitter-api branch up to speed with the latest changes in master, and not mess up recent commits to the branch. makes sense? |
|
if the goal is to merge this branch into master at a later date, you want to continue to rebase with master regularly. |
…art without and see.
An incomplete implementation, but provides most of the important stuff that would be needed to pull a home timeline from a third party client. Seems to work well enough to be useful. [hotsh#570]
Similar to home_timeline and user_timeline looks like it might be good to extract out preparing the json this commit should satisfy hotsh#572
simple start for hotsh#603 that will give a basic acceptance test that the api calls return valid JSON
- acceptance testing for the api methods that have already been implemented. - cleaned up require_relative backport to 1.8 line
user needs to be an instance variable Signed-off-by: DiogoAndre <[email protected]>
ref issue 574 Signed-off-by: DiogoAndre <[email protected]>
|
not sure if I did this rebase the right way... |
|
Closing this and adding changes in pull request #674. |
|
Blgh yeah I tried rebasing the twitter-api branch and pushing it and I had hoped that would magically make this pull req nicer, but it didn't help. Thank you for being willing to make a new one :) |
My attempt to implement the show status api referenced in #574