-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added data extracts to avoid creating tasks with no features #41
Conversation
for more information, see https://pre-commit.ci
The split by square tests are failing as I assume they need the data extract passed to them. Once fixed, I will merge and create a new release, then update fmtm-splitter on hotosm/fmtm#1642 👍 |
Nice work by the way 😄 |
for more information, see https://pre-commit.ci
These pre-commit hooks aren't being installed on my system, failing every time. |
No worries about the failing pre-commit tests here! They are failures linting the additional SQL files in the repo - I should set an exclusion 👍 To install the pre-commit hooks so they always run on the repo locally: pip install pre-commit
pre-commit install The hooks will run every time you try to commit and not allow you to commit if there are failures. git commit -m "fix: some fix" --no-verify |
Issue:
Updates:
This PR now avoids creating tasks with no features in them when the AOI is splitted using the
split_by_square
algorithm.