Creating task areas with no features should not be possible

[spwoodcock]

Describe the bug

• This is specific to the split by square algorithm.
• It's possible that sometimes a task area is generated with no features inside it.
• This happens when an AOI is not square.

To Reproduce

Project https://fmtm.hotosm.org/project/100

Expected behavior

• The task areas with no features are deleted at the end of the split_by_square function to avoid this problem.

Screenshots

You can see two small task areas that have no buildings:

Additional considerations

I imagine this problem does not exist on the complex splitting algorithm, as we handle the case already.

[Sujanadh]

We do not pass data extracts to splitbysquare in order to check if the resulting polygons contain features or not.
Options:

• Update the logic to check if the resulted tasks contains features or not in splitbysquare by passing data extracts.
• get the splitted tasks in fmtm and update there if the task contains features or not; if some tasks donot have features, delete them or merge them.

[manjitapandey]

Is the problem here only specific to features not available because the task area is small or does it implemented on tasks with more area too where there is no features. Cases could be of forest areas?

[Sujanadh]

I have made some improvements to this issue:

• updated the splitbysquare to include data extracts
• considering square polygons where atleast a data extract feature is present.

Output:
Before :

After:

AOI geojson:
durbar_poly.txt
data extracts:
durbar_exports.txt

[Sujanadh]

I couldn't see the project you mentioned, I think its already deleted can you provide me aoi and the dimension you used so that i can try it, if this new improvements solves it.
@spwoodcock

[spwoodcock]

Possibly this one?

https://fmtm.hotosm.org/project/104