fix: replace superagent-proxy with direct use of proxy-agent #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the equivalent behavior of the previous agent configuration. If a proxy URL is provided in libhoney config, a single ProxyAgent will be created with that proxy URL set for all connections. No nuanced lookup of proxy config from the environment based on target URL protocol. proxy-agent is a hefty import, but we were importing an early edition of it already via superagent-proxy.
robbkidd
force-pushed
the
robb.use-proxy-agent-directly
branch
from
2820419 to
894354b
Compare
robbkidd
changed the title
|
@robbkidd thanks for putting up this fix! any movement on this? I'd like to use libhoney-js with the fix as soon as this is merged and released |
JamieDanielson
approved these changes
Aug 16, 2023
vreynolds
pushed a commit
that referenced
this pull request
Aug 18, 2023
## Which problem is this PR solving? - adding a bit more confidence in unit testing for proxy usage as a follow-up from #389 ## Short description of the changes - extra test that confirms http headers and method are passed along to the proxy server - optional: added docker-compose for easy spinning up of proxies, along with some extra attributes for event if the proxy is in use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes
This is the equivalent behavior of the previous agent configuration. If a proxy URL is provided in libhoney config, a single ProxyAgent will be created with that proxy URL set for all connections. No nuanced lookup of proxy config from the environment based on target URL protocol.
proxy-agent is a hefty import, but we were importing an early edition of it (v5.0.0) already via superagent-proxy. Update: whew, bundlephobia really doesn't handle direct links well.
TODO?