Skip to content

Commit

Permalink
fix: replace superagent-proxy with direct use of proxy-agent (#389)
Browse files Browse the repository at this point in the history
## Which problem is this PR solving?

- Resolves #380 

## Short description of the changes

This is the equivalent behavior of the previous agent configuration. If
a proxy URL is provided in libhoney config, a single ProxyAgent will be
created with that proxy URL set for all connections. No nuanced lookup
of proxy config from the environment based on target URL protocol.

[proxy-agent is a hefty
import](https://bundlephobia.com/package/[email protected]), but we were
importing an early edition of it
([v5.0.0](https://bundlephobia.com/package/[email protected])) already
via superagent-proxy. 

---------

Co-authored-by: JamieDanielson <[email protected]>
  • Loading branch information
robbkidd and JamieDanielson authored Aug 16, 2023
1 parent c6788c2 commit 798855a
Show file tree
Hide file tree
Showing 5 changed files with 302 additions and 646 deletions.
Loading

0 comments on commit 798855a

Please sign in to comment.