Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drop node 8 #188

Merged
merged 4 commits into from
Oct 8, 2021
Merged

drop node 8 #188

merged 4 commits into from
Oct 8, 2021

Conversation

vreynolds
Copy link
Contributor

@vreynolds vreynolds commented Oct 7, 2021 •
edited
Loading

  • zhuzh up the readme
    • esdocs haven't been updated since switching to circle
    • contributors file is obsolete
    • new docs link
  • update jest things
  • update rollup things
    • built the artifact and tested with commonjs and esbuild node apps, a react app
    • removing trailing comma error from eslint config, because prettier wants to add it to the changed rollup.config files on commit --> we already run prettier on everything with lint-staged, so preferring prettier style
  • package lock file version updated to 2, because I'm running npm 7 which is the present and the future
  • closes Drop support for Node 8 #140

@vreynolds
ci, package, readme
612abe7
@vreynolds
bump jest to 27.2.4
4baf662
@vreynolds
bump babel-jest to 27.2.4
f704615
@vreynolds
bump rollup to 2.58.0
ae1c758 
- bump @rollup/plugin-commonjs to 21.0.0
- bump @rollup/plugin-json to 4.1.0
- bump @rollup/plugin-node-resolver to 13.0.5
- bump @rollup/plugin-replace to 3.0.0
@vreynolds vreynolds added type: maintenance The necessary chores to keep the dust off. version: bump major A PR that breaks backwards compatibility. labels Oct 7, 2021
@vreynolds vreynolds marked this pull request as ready for review October 7, 2021 19:51
@vreynolds vreynolds requested a review from a team October 7, 2021 19:51
@vreynolds vreynolds merged commit 9e7daa9 into main Oct 8, 2021
@vreynolds vreynolds deleted the vera.drop-node-8 branch October 8, 2021 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cartermp cartermp cartermp approved these changes

Assignees
No one assigned
Labels
type: maintenance The necessary chores to keep the dust off. version: bump major A PR that breaks backwards compatibility.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Drop support for Node 8
2 participants
@vreynolds @cartermp