Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: De-bump Npgsql.OpenTelemetry to work with LTS EntityFramework #348

Merged
merged 4 commits into from
Apr 25, 2023

Conversation

JamieDanielson
Copy link
Contributor

@JamieDanielson JamieDanielson commented Apr 25, 2023

Which problem is this PR solving?

  • error when using with EFCore Encountered Exception of type MethodAccessException: Attempt by method 'Npgsql.EntityFrameworkCore.PostgreSQL.Storage.Internal.NpgsqlRelationalConnection.get_CurrentAmbientTransaction()' to access method 'Npgsql.NpgsqlConnection.get_Settings()' failed

Short description of the changes

  • Similar to De-bump Npgsql.OpenTelemetry to 6.0.7 to avoid collisions with LTS entityframework #298 there seem to be some issues with EntityFramework with .NET 7. This reverts back to 6.0.7, but adds a bump to a later patch version of 6.0.9.
  • If this indeed solves the problem, a follow-up issue should be added for separating out versions for .NET 6 and .NET 7. We don't currently include net7.0 in this package so it doesn't make sense to add that conditional block here.
  • In the meantime, I added a dependabot ignore block so we don't inadvertently update again; we can remove it once we update with conditionals for .NET 7.

@JamieDanielson JamieDanielson requested a review from a team April 25, 2023 17:19
@JamieDanielson JamieDanielson self-assigned this Apr 25, 2023
@JamieDanielson JamieDanielson added type: maintenance The necessary chores to keep the dust off. version: bump minor A PR that adds behavior, but is backwards-compatible. labels Apr 25, 2023
@JamieDanielson JamieDanielson changed the title maint: De-bump Npgsql.OpenTelemetry to work with LTS EntityFramework fix: De-bump Npgsql.OpenTelemetry to work with LTS EntityFramework Apr 25, 2023
@JamieDanielson JamieDanielson added type: bug Something isn't working and removed type: maintenance The necessary chores to keep the dust off. labels Apr 25, 2023
@JamieDanielson JamieDanielson merged commit 027d447 into main Apr 25, 2023
@JamieDanielson JamieDanielson deleted the jamie.debump-npgsql branch April 25, 2023 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working version: bump minor A PR that adds behavior, but is backwards-compatible.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants