De-bump Npgsql.OpenTelemetry to 6.0.7 to avoid collisions with LTS entityframework #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cartermp can you add semver labels plz? |
cartermp
added
the
version: bump minor
pkanal
approved these changes
Oct 14, 2022
MikeGoldsmith
approved these changes
Oct 18, 2022
JamieDanielson
added a commit
that referenced
this pull request
Apr 25, 2023
) ## Which problem is this PR solving? - error when using with EFCore `Encountered Exception of type MethodAccessException: Attempt by method 'Npgsql.EntityFrameworkCore.PostgreSQL.Storage.Internal.NpgsqlRelationalConnection.get_CurrentAmbientTransaction()' to access method 'Npgsql.NpgsqlConnection.get_Settings()' failed` ## Short description of the changes - Similar to #298 there seem to be some issues with EntityFramework with .NET 7. This reverts back to 6.0.7, but adds a bump to a later patch version of 6.0.9. - If this indeed solves the problem, a follow-up issue should be added for separating out versions for .NET 6 and .NET 7. We don't currently include net7.0 in this package so it doesn't make sense to add that conditional block here. - In the meantime, I added a dependabot ignore block so we don't inadvertently update again; we can remove it once we update with conditionals for .NET 7.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #297
We may also want to consider a
ItemGroup Condition=" '$(TargetFramework)' == 'net7.0'block for this package and its .NET 7 version in the future, but I'd like to avoid that mess as long as possible.This makes it so that the Npgsql dependency doesn't get all clobbered up when using LTS .NET and EntityFramework with Npgsql.