Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENABLE_LOCAL_VISUALIZATIONS -> HONEYCOMB_ENABLE_LOCAL_VISUALIZATIONS #275

Merged
merged 1 commit into from
Sep 26, 2022
Merged

ENABLE_LOCAL_VISUALIZATIONS -> HONEYCOMB_ENABLE_LOCAL_VISUALIZATIONS #275

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Honeycomb.OpenTelemetry/EnvironmentOptions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ internal class EnvironmentOptions
private const string SampleRateKey = "HONEYCOMB_SAMPLE_RATE";
private const string ServiceNameKey = "OTEL_SERVICE_NAME";
private const string ServiceVersionKey = "SERVICE_VERSION";
private const string EnableLocalVisualizationsKey = "ENABLE_LOCAL_VISUALIZATIONS";
private const string EnableLocalVisualizationsKey = "HONEYCOMB_ENABLE_LOCAL_VISUALIZATIONS";
private const string DebugKey = "DEBUG";
private const uint DefaultSampleRate = 1;
private const string DefaultApiEndpoint = "https://api.honeycomb.io:443";
Expand Down
4 changes: 2 additions & 2 deletions test/Honeycomb.OpenTelemetry.Tests/EnvironmentOptionsTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ public void Can_get_options_from_env_vars()
{"HONEYCOMB_SAMPLE_RATE", "10"},
{"OTEL_SERVICE_NAME", "my-service-name"},
{"SERVICE_VERSION", "my-service-version"},
{"ENABLE_LOCAL_VISUALIZATIONS", "true" },
{"HONEYCOMB_ENABLE_LOCAL_VISUALIZATIONS", "true" },
{"DEBUG", "true"}
};
var options = new EnvironmentOptions(values);
Expand Down Expand Up @@ -77,7 +77,7 @@ public void EnvironmentOptionsCanOverrideHoneycombOptions()
{"HONEYCOMB_SAMPLE_RATE", "10"},
{"OTEL_SERVICE_NAME", "my-env-service-name"},
{"SERVICE_VERSION", "my-env-service-version"},
{"ENABLE_LOCAL_VISUALIZATIONS", "true" },
{"HONEYCOMB_ENABLE_LOCAL_VISUALIZATIONS", "true" },
{"DEBUG", "true"}
};
var options = new EnvironmentOptions(values);
Expand Down