Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENABLE_LOCAL_VISUALIZATIONS -> HONEYCOMB_ENABLE_LOCAL_VISUALIZATIONS #275

Merged
merged 1 commit into from
Sep 26, 2022
Merged

ENABLE_LOCAL_VISUALIZATIONS -> HONEYCOMB_ENABLE_LOCAL_VISUALIZATIONS #275

merged 1 commit into from
Sep 26, 2022

Conversation

cartermp
Copy link
Member

Why the name change?

  • This is the name in the go distro, so we'd have to change one or the other
  • This aligns with the rest of the honeycomb-specific environment variables, where HONEYCOMB comes first. I think we should probably do that

@cartermp cartermp requested review from a team and JamieDanielson September 23, 2022 21:43
@cartermp cartermp mentioned this pull request Sep 24, 2022
Closed
@MikeGoldsmith MikeGoldsmith merged commit 2af039e into main Sep 26, 2022
@MikeGoldsmith MikeGoldsmith deleted the cartermp/viz-rename branch September 26, 2022 09:43
@MikeGoldsmith MikeGoldsmith added this to the GA Release milestone Sep 27, 2022
@JamieDanielson JamieDanielson added the version: bump minor A PR that adds behavior, but is backwards-compatible. label Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeGoldsmith MikeGoldsmith MikeGoldsmith approved these changes

@JamieDanielson JamieDanielson Awaiting requested review from JamieDanielson

Assignees
No one assigned
Labels
version: bump minor A PR that adds behavior, but is backwards-compatible.
Projects
None yet
Milestone
GA Release
Development

Successfully merging this pull request may close these issues.
3 participants
@cartermp @MikeGoldsmith @JamieDanielson