Add grpc smoke tests #264
Merged
Add grpc smoke tests #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkanal
added
type: maintenance
pkanal
force-pushed
the
purvi/grpc-smoke-tests
branch
from
4a2ef13 to
ccd96a7
Compare
vreynolds
approved these changes
Sep 21, 2022
There was a problem hiding this comment.
🎉 that's dope!
as far as metrics/logs.. I initially left metrics out of scope in the spirit of "let's get the most happiest/common path in for GA and iterate later" (and of course we haven't had logs until recently)
I'm inclined to add those as issue for future us, but not hold up the GA release. wdyt?
JamieDanielson
added
the
version: no bump
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not merge Depends on #263 being merged firstWhich problem is this PR solving?
Adds smoke tests for the example
aspnetcoreexample app over grpc. These will eventually be used for CI smoke tests to ensure our core functionality works as expected.Short description of the changes
app-sdk-grpcservice tosmoke-tests/docker-compose.ymlthat starts the example app with the traces endpoint configured to send traces over grpc to the collector and set the protocol togrpcsmoke-tests/smoke-sdk-http.batsthat test manual instrumentation for tracesHow to test
cd smoke && bats ./smoke-sdk-grpc.batsYou should see two passing tests
Out of scope