Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Adds smoke tests for the example
aspnetcore
example app over http/protobuf. These will eventually be used for CI smoke tests to ensure our core functionality works as expected.Short description of the changes
app-sdk-http
service tosmoke-tests/docker-compose.yml
that starts the example app with the traces endpoint configured to send traces over http to the collector and set the protocol tohttp/protobuf
some-tests/test_helpers/utilities.bash
which is largely the same as the utilities in the Java distro, the only difference is the string we're looking for to indicate that the app is ready.smoke-tests/smoke-sdk-http.bats
that test manual instrumentation for tracesHow to test
cd smoke && bats ./smoke-sdk-http.bats
You should see two passing tests
Out of scope
HONEYCOMB_API_ENDPOINT
does not appendv1/traces
by default. Is this something we want to add in? Our distro spec doesn't mention anything about it, but our Java distro seems to append the path.