Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add http/protobuf smoke tests #263

Merged
merged 7 commits into from
Sep 21, 2022
Merged

Add http/protobuf smoke tests #263

merged 7 commits into from
Sep 21, 2022

Conversation

pkanal
Copy link
Contributor

@pkanal pkanal commented Sep 21, 2022

Which problem is this PR solving?

Adds smoke tests for the example aspnetcore example app over http/protobuf. These will eventually be used for CI smoke tests to ensure our core functionality works as expected.

Short description of the changes

  • Added app-sdk-http service to smoke-tests/docker-compose.yml that starts the example app with the traces endpoint configured to send traces over http to the collector and set the protocol to http/protobuf
  • Added some-tests/test_helpers/utilities.bash which is largely the same as the utilities in the Java distro, the only difference is the string we're looking for to indicate that the app is ready.
  • Added bats tests in smoke-tests/smoke-sdk-http.bats that test manual instrumentation for traces

How to test

  1. Fetch this branch locally and check it out
  2. cd smoke && bats ./smoke-sdk-http.bats

You should see two passing tests

Out of scope

  • While working on this I realized that HONEYCOMB_API_ENDPOINT does not append v1/traces by default. Is this something we want to add in? Our distro spec doesn't mention anything about it, but our Java distro seems to append the path.
  • Do we want to add any metrics or logs tests?

@pkanal pkanal changed the title Purvi/http smoke tests Add http/protobuf smoke tests Sep 21, 2022
@pkanal pkanal self-assigned this Sep 21, 2022
@pkanal pkanal added type: enhancement New feature or request version: no bump A PR with maintenance or doc changes that aren't included in a release. labels Sep 21, 2022
@pkanal pkanal marked this pull request as ready for review September 21, 2022 19:09
@pkanal pkanal requested review from a team, emilyashley and MikeGoldsmith September 21, 2022 19:09
@pkanal pkanal added type: maintenance The necessary chores to keep the dust off. and removed type: enhancement New feature or request labels Sep 21, 2022
@pkanal pkanal mentioned this pull request Sep 21, 2022
Copy link
Contributor

@MikeGoldsmith MikeGoldsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍🏻

smoke-tests/smoke-sdk-http.bats Outdated Show resolved Hide resolved
@pkanal pkanal merged commit 10770b1 into main Sep 21, 2022
@pkanal pkanal deleted the purvi/http-smoke-tests branch September 21, 2022 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: maintenance The necessary chores to keep the dust off. version: no bump A PR with maintenance or doc changes that aren't included in a release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[smoke tests] add smoke-sdk-http bats test
2 participants