bug: DeviceId returns incomplete MAC address #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snprintf works with n-1 characters expected behaviour: DeviceId is 12 characters behaviour: only 11 characters are returned (resulting in a "incomplete" mac address)
bertmelis
changed the title
|
Thanks! |
euphi
added a commit
to euphi/homie-esp8266
that referenced
this pull request
Mar 6, 2017
* 📝 Add Gitter badge * 📝 Add link to the Gitter in the ISSUE_TEMPLATE * 🐛 Fix loopFunction being called too early before MQTT connection is established - closes homieiot#260 (homieiot#290) * 👕 Fix lint * ✨ Add destructor to HomieNode, that will abort() (homieiot#286) * Added destructor to HomieNode, that will abort() * 🎨 Log wifi client IP address upon connection. (homieiot#280) This removes the need to hunt the device IP when debugging connectivity issues. * 📝 Mention troubleshooting page in issue template * 👕 Fix cpplint failure, causing travis CI to be red (homieiot#291) E.g. https://travis-ci.org/marvinroger/homie-esp8266/jobs/199213998 Ran the following command successfully: cpplint --repository=. --recursive \ --filter=-whitespace/line_length,-legal/copyright,-runtime/printf,-build/include,-build/namespace,-runtime/int \ ./src * 🔥 Remove MQTT ack logging * 🐎 Make tiny optimizations * 🎨 Add a comma to the wifi connected log * 🎨 Reorganize next boot mode feature * 🐎 Check length on input fields (homieiot#292) * Fixing loopFunction being called too early before MQTT connection is established * Started cleanup of strcpy/sprintf to include length check. * Fixed warning under Interface.cpp * 👕 Fix lint * 🎨 Print firmware name and version at boot * 🐛 Fix DeviceId incomplete MAC address (homieiot#296) snprintf works with n-1 characters expected behaviour: DeviceId is 12 characters behaviour: only 11 characters are returned (resulting in a "incomplete" mac address) * :bug Fix millis() overflow in uptime - fix homieiot#299 (homieiot#302) Corrected type declaration for correct overflow handling of millis function in uptime calculation
euphi
added a commit
to euphi/homie-esp8266
that referenced
this pull request
Mar 6, 2017
* 📝 Add Gitter badge * 📝 Add link to the Gitter in the ISSUE_TEMPLATE * 🐛 Fix loopFunction being called too early before MQTT connection is established - closes homieiot#260 (homieiot#290) * 👕 Fix lint * ✨ Add destructor to HomieNode, that will abort() (homieiot#286) * Added destructor to HomieNode, that will abort() * 🎨 Log wifi client IP address upon connection. (homieiot#280) This removes the need to hunt the device IP when debugging connectivity issues. * 📝 Mention troubleshooting page in issue template * 👕 Fix cpplint failure, causing travis CI to be red (homieiot#291) E.g. https://travis-ci.org/marvinroger/homie-esp8266/jobs/199213998 Ran the following command successfully: cpplint --repository=. --recursive \ --filter=-whitespace/line_length,-legal/copyright,-runtime/printf,-build/include,-build/namespace,-runtime/int \ ./src * 🔥 Remove MQTT ack logging * 🐎 Make tiny optimizations * 🎨 Add a comma to the wifi connected log * 🎨 Reorganize next boot mode feature * 🐎 Check length on input fields (homieiot#292) * Fixing loopFunction being called too early before MQTT connection is established * Started cleanup of strcpy/sprintf to include length check. * Fixed warning under Interface.cpp * 👕 Fix lint * 🎨 Print firmware name and version at boot * 🐛 Fix DeviceId incomplete MAC address (homieiot#296) snprintf works with n-1 characters expected behaviour: DeviceId is 12 characters behaviour: only 11 characters are returned (resulting in a "incomplete" mac address) * :bug Fix millis() overflow in uptime - fix homieiot#299 (homieiot#302) Corrected type declaration for correct overflow handling of millis function in uptime calculation
euphi
added a commit
that referenced
this pull request
Mar 10, 2019
…te (#490) * First proof of concept for $broadcast feature - $broadcast is handled and globalInputHandler is called - still many TODOs, e.g. support for other callbacks or splitted MQTT message (make use of payload buffer) * $broadcast - use payload buffer + minor improvements * Added $broadcast handler + added comments to BootNormal.cpp to explain handling of incoming MQTT message * Make HomieNode CONST again! :-) * fixed wrong merge * Added destructor to HomieNode, that will abort() * Local develop (#3) * 📝 Add Gitter badge * 📝 Add link to the Gitter in the ISSUE_TEMPLATE * 🐛 Fix loopFunction being called too early before MQTT connection is established - closes #260 (#290) * 👕 Fix lint * ✨ Add destructor to HomieNode, that will abort() (#286) * Added destructor to HomieNode, that will abort() * 🎨 Log wifi client IP address upon connection. (#280) This removes the need to hunt the device IP when debugging connectivity issues. * 📝 Mention troubleshooting page in issue template * 👕 Fix cpplint failure, causing travis CI to be red (#291) E.g. https://travis-ci.org/marvinroger/homie-esp8266/jobs/199213998 Ran the following command successfully: cpplint --repository=. --recursive \ --filter=-whitespace/line_length,-legal/copyright,-runtime/printf,-build/include,-build/namespace,-runtime/int \ ./src * 🔥 Remove MQTT ack logging * 🐎 Make tiny optimizations * 🎨 Add a comma to the wifi connected log * 🎨 Reorganize next boot mode feature * 🐎 Check length on input fields (#292) * Fixing loopFunction being called too early before MQTT connection is established * Started cleanup of strcpy/sprintf to include length check. * Fixed warning under Interface.cpp * 👕 Fix lint * 🎨 Print firmware name and version at boot * 🐛 Fix DeviceId incomplete MAC address (#296) snprintf works with n-1 characters expected behaviour: DeviceId is 12 characters behaviour: only 11 characters are returned (resulting in a "incomplete" mac address) * :bug Fix millis() overflow in uptime - fix #299 (#302) Corrected type declaration for correct overflow handling of millis function in uptime calculation * Local develop (#4) * 📝 Add Gitter badge * 📝 Add link to the Gitter in the ISSUE_TEMPLATE * 🐛 Fix loopFunction being called too early before MQTT connection is established - closes #260 (#290) * 👕 Fix lint * ✨ Add destructor to HomieNode, that will abort() (#286) * Added destructor to HomieNode, that will abort() * 🎨 Log wifi client IP address upon connection. (#280) This removes the need to hunt the device IP when debugging connectivity issues. * 📝 Mention troubleshooting page in issue template * 👕 Fix cpplint failure, causing travis CI to be red (#291) E.g. https://travis-ci.org/marvinroger/homie-esp8266/jobs/199213998 Ran the following command successfully: cpplint --repository=. --recursive \ --filter=-whitespace/line_length,-legal/copyright,-runtime/printf,-build/include,-build/namespace,-runtime/int \ ./src * 🔥 Remove MQTT ack logging * 🐎 Make tiny optimizations * 🎨 Add a comma to the wifi connected log * 🎨 Reorganize next boot mode feature * 🐎 Check length on input fields (#292) * Fixing loopFunction being called too early before MQTT connection is established * Started cleanup of strcpy/sprintf to include length check. * Fixed warning under Interface.cpp * 👕 Fix lint * 🎨 Print firmware name and version at boot * 🐛 Fix DeviceId incomplete MAC address (#296) snprintf works with n-1 characters expected behaviour: DeviceId is 12 characters behaviour: only 11 characters are returned (resulting in a "incomplete" mac address) * :bug Fix millis() overflow in uptime - fix #299 (#302) Corrected type declaration for correct overflow handling of millis function in uptime calculation * Added Homie-Online-State.xml * Homie-Online-States.xml * Proposal to optionally run HomieNode::loop() also in disconnected state * Delete Homie-Online-State.xml * Delete Untitled Diagram.xml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
snprintf works with n-1 characters
expected behaviour: DeviceId is 12 characters
behaviour: only 11 characters are returned
(resulting in a "incomplete" mac address)
DeviceID.hpp also states
static char _deviceId[MAX_MAC_STRING_LENGTH + 1];