Add config for MQTT port #3
Comments
|
I think this is a good idea, but the fact is an Homie server is actually 2 servers: the MQTT broker on 35589 and the OTA HTTP server on port 35590, that respond on the What do you think about it? If you have another ideas, even breaking ones, go ahead! Homie is still young and, well, not used by a lot of people so there will probably be a lot of breaking changes before reaching 1.0.0. ;) |
|
Nice. I'll do that. A "breaking" idea could be to have a more flexible option system. With the current options by default + other that a dev can declare in his setup for a particular device. But it might be a wrong way as such option can be given by MQTT... |
|
What do you mean by options?
|
…te (#490) * First proof of concept for $broadcast feature - $broadcast is handled and globalInputHandler is called - still many TODOs, e.g. support for other callbacks or splitted MQTT message (make use of payload buffer) * $broadcast - use payload buffer + minor improvements * Added $broadcast handler + added comments to BootNormal.cpp to explain handling of incoming MQTT message * Make HomieNode CONST again! :-) * fixed wrong merge * Added destructor to HomieNode, that will abort() * Local develop (#3) * 📝 Add Gitter badge * 📝 Add link to the Gitter in the ISSUE_TEMPLATE * 🐛 Fix loopFunction being called too early before MQTT connection is established - closes #260 (#290) * 👕 Fix lint * ✨ Add destructor to HomieNode, that will abort() (#286) * Added destructor to HomieNode, that will abort() * 🎨 Log wifi client IP address upon connection. (#280) This removes the need to hunt the device IP when debugging connectivity issues. * 📝 Mention troubleshooting page in issue template * 👕 Fix cpplint failure, causing travis CI to be red (#291) E.g. https://travis-ci.org/marvinroger/homie-esp8266/jobs/199213998 Ran the following command successfully: cpplint --repository=. --recursive \ --filter=-whitespace/line_length,-legal/copyright,-runtime/printf,-build/include,-build/namespace,-runtime/int \ ./src * 🔥 Remove MQTT ack logging * 🐎 Make tiny optimizations * 🎨 Add a comma to the wifi connected log * 🎨 Reorganize next boot mode feature * 🐎 Check length on input fields (#292) * Fixing loopFunction being called too early before MQTT connection is established * Started cleanup of strcpy/sprintf to include length check. * Fixed warning under Interface.cpp * 👕 Fix lint * 🎨 Print firmware name and version at boot * 🐛 Fix DeviceId incomplete MAC address (#296) snprintf works with n-1 characters expected behaviour: DeviceId is 12 characters behaviour: only 11 characters are returned (resulting in a "incomplete" mac address) * :bug Fix millis() overflow in uptime - fix #299 (#302) Corrected type declaration for correct overflow handling of millis function in uptime calculation * Local develop (#4) * 📝 Add Gitter badge * 📝 Add link to the Gitter in the ISSUE_TEMPLATE * 🐛 Fix loopFunction being called too early before MQTT connection is established - closes #260 (#290) * 👕 Fix lint * ✨ Add destructor to HomieNode, that will abort() (#286) * Added destructor to HomieNode, that will abort() * 🎨 Log wifi client IP address upon connection. (#280) This removes the need to hunt the device IP when debugging connectivity issues. * 📝 Mention troubleshooting page in issue template * 👕 Fix cpplint failure, causing travis CI to be red (#291) E.g. https://travis-ci.org/marvinroger/homie-esp8266/jobs/199213998 Ran the following command successfully: cpplint --repository=. --recursive \ --filter=-whitespace/line_length,-legal/copyright,-runtime/printf,-build/include,-build/namespace,-runtime/int \ ./src * 🔥 Remove MQTT ack logging * 🐎 Make tiny optimizations * 🎨 Add a comma to the wifi connected log * 🎨 Reorganize next boot mode feature * 🐎 Check length on input fields (#292) * Fixing loopFunction being called too early before MQTT connection is established * Started cleanup of strcpy/sprintf to include length check. * Fixed warning under Interface.cpp * 👕 Fix lint * 🎨 Print firmware name and version at boot * 🐛 Fix DeviceId incomplete MAC address (#296) snprintf works with n-1 characters expected behaviour: DeviceId is 12 characters behaviour: only 11 characters are returned (resulting in a "incomplete" mac address) * :bug Fix millis() overflow in uptime - fix #299 (#302) Corrected type declaration for correct overflow handling of millis function in uptime calculation * Added Homie-Online-State.xml * Homie-Online-States.xml * Proposal to optionally run HomieNode::loop() also in disconnected state * Delete Homie-Online-State.xml * Delete Untitled Diagram.xml
To use it with a std MQTT broker it could be nice to make MQTT broker port configurable.
It's straightforward to add such option, however in a "pure" Homie framework it's just an other useless option...
What do you think to add an
homie_portoption that take the value from theHOMIE_PORTconstant if not given in the config JSON ?I can propose a PR in this sense.
The text was updated successfully, but these errors were encountered: