Fix doc and changelog API response for orphaned addons #5082
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Follow-up to #5064 . It appears orphaned addons return 400 responses to
/changelog
that the frontend cannot interpret. While digging I noticed that the/documentation
API has the same problem, it just hasn't come up yet (probably becauseupdate
entities do not hit it in the background like they do with the changelog).Changed both these APIs so they go back to returning 200 responses with the error as text. As noted in the other PR, we should really handle this differently. Although in this case I'm not sure a 404 makes sense since this is a bit odd. Still it would be nice to have the API correctly report an error and the frontend show the appropriate text rather then having supervisor return error text to display to users.
Type of change
Additional information
Checklist
ruff format supervisor tests
)If API endpoints of add-on configuration are added/changed: