-
Notifications
You must be signed in to change notification settings - Fork 668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix no changelog API response #5064
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agners
force-pushed
the
no-changelog-response
branch
from
May 7, 2024 06:50
a63ea5f
to
6881927
Compare
sairon
approved these changes
May 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, it's downfall of this change to be precise. I will take a look if it's the only place that relied on this rather weird handling but this PR fixes the issue, so 👍
agners
approved these changes
May 7, 2024
sairon
reviewed
May 7, 2024
agners
reviewed
May 7, 2024
Co-authored-by: Stefan Agner <[email protected]>
sairon
reviewed
May 7, 2024
Co-authored-by: Jan Čermák <[email protected]>
This was referenced May 7, 2024
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
The status code of the changelog API when an addon had no changelog was accidently chnaged in #4972 . This PR changes it back to a 200 in this case and adds a unit test. It also fixes the
/store/addons/{slug}/changelog
API as it appears that hasn't worked for a long time (frontend is still using the supposedly deprecated/addons/{slug}/changelog
and that did work).As an aside this feels very hacky. We should simply return a 404 and the frontend should have the text to display in that case with localization. Supervisor should not be returning the message presented directly to users in this case.
Type of change
Additional information
Checklist
ruff format supervisor tests
)If API endpoints of add-on configuration are added/changed: