Revert Home Assistant configuration to /config
#4697
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
With the new add-on config feature the intention is to provide a good location for add-on specific configurations. Currently, add-ons such as Node RED or ESPHome use the Home Assistant config directory because this location is accessible to the user (via Samba VSCode add-on etc.).
To make it clear to add-on developer that the new intention is to use add-on specific config, the implementation now bind mounts the add-on configuration directory to
/config
. And since some add-ons still need access to the Home Assistant configuration, its config folder is mounted to/homeassistant
under the new scheme.However, users do know and use the path
/config
, and edit things e.g. through the SSH or VS Code add-on. Also/config
is still the directory from inside the Core container. The path is also in documentations and how-to's.For SSH/VS Code add-on we could work around using a symlink (pointing
/config
->/homeassistant
e.g. as suggested in home-assistant/addons#3304), but that only works as long as these add-ons don't have a add-on config themselfs.This all has very high confusion potential, for not much gain. The renaming is mainly "developer friendly", but not really user friendly.
Let's minimize potential confusion, and keep things where they are. The Home Assistant config directory stays at `/config, in all cases, everywhere.
Map the new add-on configuration directory to
/addon_config
.Type of change
Additional information
Checklist
black --fast supervisor tests
)If API endpoints of add-on configuration are added/changed: