Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't remove add-on conifg on add-on removal #4696

Merged
merged 2 commits into from
Nov 11, 2023

Conversation

agners
Copy link
Member

@agners agners commented Nov 11, 2023

Proposed change

Do not remove the add-on config when the add-on gets uninstalled. The add-on config directory contains user configuration which the user might like to retain even when uninstalling the add-on. The user can easily delete the directory on his own since it is user can access the directory.

In the future we should consider adding an option at uninstall time to offer removing this directory. But meanwhile not removing it is the better default.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to the supervisor)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to cli pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast supervisor tests)
  • Tests have been added to verify that the new code works.

If API endpoints of add-on configuration are added/changed:

Do not remove the add-on config when the add-on gets uninstalled.
The add-on config directory contains user configuration which the
user might like to retain even when uninstalling the add-on. The
user can easily delete the directory on his own since it is user
can access the directory.

In the future we should consider adding an option at uninstall time
to offer removing this directory. But meanwhile not removing it is
the better default.
@agners agners marked this pull request as ready for review November 11, 2023 12:01
@frenck frenck merged commit 5f45810 into main Nov 11, 2023
22 checks passed
@frenck frenck deleted the dont-delete-addon-config-on-remove branch November 11, 2023 12:23
agners added a commit to home-assistant/developers.home-assistant that referenced this pull request Nov 11, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Nov 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants