Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dbus-fast unpack_variants option #3885

Merged
merged 2 commits into from
Sep 21, 2022
Merged

Use dbus-fast unpack_variants option #3885

merged 2 commits into from
Sep 21, 2022

Conversation

mdegat01
Copy link
Contributor

@mdegat01 mdegat01 commented Sep 21, 2022

Proposed change

Signature removal from responses has been incorporated into dbus-fast with Bluetooth-Devices/dbus-fast#20 so we now use the unpack_variants option the library includes.

Additionally after Bluetooth-Devices/dbus-fast#22 dbus-fast supports varargs callbacks on signals so when we want to use an annotated method as a callback we no longer need to wrap it in a lambda. This part required a small enhancement to handle kwargs (Bluetooth-Devices/dbus-fast#26) hence the bump to 1.7.0

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to the supervisor)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to cli pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast supervisor tests)
  • Tests have been added to verify that the new code works.

If API endpoints of add-on configuration are added/changed:

@mdegat01 mdegat01 added dependencies Updates of external dependencies refactor A code change that neither fixes a bug nor adds a feature labels Sep 21, 2022
@mdegat01 mdegat01 requested a review from pvizeli September 21, 2022 17:06
@pvizeli pvizeli merged commit c24b811 into main Sep 21, 2022
@pvizeli pvizeli deleted the use-dbus-fast-features branch September 21, 2022 18:52
@github-actions github-actions bot locked and limited conversation to collaborators Sep 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed dependencies Updates of external dependencies refactor A code change that neither fixes a bug nor adds a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants