feat: allow varargs callback for signals #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 80.42% // Head: 80.77% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #22 +/- ##
==========================================
+ Coverage 80.42% 80.77% +0.35%
==========================================
Files 24 24
Lines 2799 2799
Branches 602 602
==========================================
+ Hits 2251 2261 +10
+ Misses 340 334 -6
+ Partials 208 204 -4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
mdegat01
commented
Sep 15, 2022
| @@ -118,8 +118,10 @@ def _message_handler(self, msg): | |||
| def _add_signal(self, intr_signal, interface): | |||
| def on_signal_fn(fn): | |||
| fn_signature = inspect.signature(fn) | |||
| if not callable(fn) or len(fn_signature.parameters) != len( | |||
There was a problem hiding this comment.
Just wanted to note that remove of not callable(fn) from here was intentional and is backwards compatible. That was never called. If fn was not callable then inspect.signature already raised a TypeError. I added a test confirm this behavior below.
mdegat01
force-pushed
the
varargs-signal-callback
branch
from
eced049 to
eeb6a2d
Compare
bdraco
approved these changes
Sep 15, 2022
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The high level client currently does not support callbacks for signals with a varargs parameter. This adds support for that.