Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare 14.0.rc3 #3707

Merged
merged 5 commits into from
Dec 2, 2024
Merged

Prepare 14.0.rc3 #3707

merged 5 commits into from
Dec 2, 2024

Conversation

sairon
Copy link
Member

@sairon sairon commented Dec 2, 2024

Summary by CodeRabbit

Release Notes

  • New Features

    • Updated build process with refined logic for publishing builds and versioning.
    • Introduced mandatory input for publishing artifacts during manual builds.
  • Bug Fixes

    • Enhanced boot process for Raspberry Pi Compute Module 5 by disabling SD and SDIO modes on eMMC, improving boot time by approximately 100 seconds.
    • Resolved random hangs during I/O operations by disabling Command Queue Engine (CQE) support on eMMC.
  • Version Updates

    • Incremented Linux kernel version across multiple configurations from 6.6.62 to 6.6.63.
    • Updated version suffix from "rc2" to "rc3" indicating a new release candidate.

sairon and others added 5 commits December 2, 2024 17:50
For yet unknown root cause, the eMMC interface sometimes fails to initialize
properly, delaying boot for up to 130 seconds. This can be reduced by ~100s by
disabling SD and SDIO modes on the sdio1 interface used for mmc0 before a
better patch is found.

(cherry picked from commit 489de0b)
The I/O operations on the eMMC can sometimes fail and lock up completely, and
disabling CQE on the sdio1 (mmc0) interface seems to solve the issue. While it
is a known (and potentially resolved) issue [1] for SD cards in Raspberry Pi's
Linux fork, it is not acknowledged neither resolved for CM5's eMMC. With CQE
enabled, the device usually locks up within the first 10 first boots, when the
swap file is being created. After disabling CQE, no error occurred after more
that 100 cold boots (every time with swap file removed).

[1] https://github.com/raspberrypi/linuxissues/6349

(cherry picked from commit c514d6b)
Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 6.9.0 to 6.10.0.
- [Release notes](https://github.com/docker/build-push-action/releases)
- [Commits](docker/build-push-action@v6.9.0...v6.10.0)

---
updated-dependencies:
- dependency-name: docker/build-push-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
(cherry picked from commit e0ccf39)
@sairon sairon requested a review from agners December 2, 2024 16:52
Copy link

coderabbitai bot commented Dec 2, 2024

📝 Walkthrough

Walkthrough

The pull request includes updates to various configuration files and the workflow for the Home Assistant Operating System build. Key changes involve updating the Docker action version, refining the logic for build publishing and versioning, and incrementing the Linux kernel version across multiple configurations from 6.6.62 to 6.6.63. Additionally, device tree modifications for the Raspberry Pi Compute Module 5 address eMMC initialization issues by disabling certain modes and features. The version suffix in the meta configuration has also been updated from "rc2" to "rc3".

Changes

File Change Summary
.github/workflows/build.yaml Updated docker/build-push-action to v6.10.0, marked publish as required, refined publishing logic, adjusted version_dev timestamp logic, modified Get channel step for release status, expanded artifact upload conditions.
Documentation/kernel.md Updated kernel version for multiple boards from 6.6.62 to 6.6.63.
buildroot-external/board/raspberrypi/yellow/patches/linux/0018-ARM-dts-bcm2712-yellow-Disable-SD-SDIO-modes-on-eMMC.patch Modified device tree to disable SD/SDIO modes on eMMC to improve boot time.
buildroot-external/board/raspberrypi/yellow/patches/linux/0019-ARM-dts-bcm2712-yellow-Disable-CQE-on-eMMC-interface.patch Modified device tree to disable CQE support on eMMC to resolve I/O blocking issues.
buildroot-external/configs/*.defconfig Incremented BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE from 6.6.62 to 6.6.63 in multiple config files.
buildroot-external/meta Updated VERSION_SUFFIX from "rc2" to "rc3".

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Workflow
    participant Docker
    participant ArtifactStorage

    User->>Workflow: Trigger build (manual)
    Workflow->>Docker: Build image
    Docker->>Workflow: Image built
    Workflow->>Workflow: Check publish conditions
    alt Publish required
        Workflow->>ArtifactStorage: Upload artifacts
        ArtifactStorage-->>Workflow: Artifacts uploaded
    end
    Workflow-->>User: Build completed
Loading

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 9153203 and 2f49a83.

📒 Files selected for processing (17)
  • .github/workflows/build.yaml (1 hunks)
  • Documentation/kernel.md (1 hunks)
  • buildroot-external/board/raspberrypi/yellow/patches/linux/0018-ARM-dts-bcm2712-yellow-Disable-SD-SDIO-modes-on-eMMC.patch (1 hunks)
  • buildroot-external/board/raspberrypi/yellow/patches/linux/0019-ARM-dts-bcm2712-yellow-Disable-CQE-on-eMMC-interface.patch (1 hunks)
  • buildroot-external/configs/generic_aarch64_defconfig (1 hunks)
  • buildroot-external/configs/generic_x86_64_defconfig (1 hunks)
  • buildroot-external/configs/green_defconfig (1 hunks)
  • buildroot-external/configs/khadas_vim3_defconfig (1 hunks)
  • buildroot-external/configs/odroid_c2_defconfig (1 hunks)
  • buildroot-external/configs/odroid_c4_defconfig (1 hunks)
  • buildroot-external/configs/odroid_m1_defconfig (1 hunks)
  • buildroot-external/configs/odroid_m1s_defconfig (1 hunks)
  • buildroot-external/configs/odroid_n2_defconfig (1 hunks)
  • buildroot-external/configs/odroid_xu4_defconfig (1 hunks)
  • buildroot-external/configs/ova_defconfig (1 hunks)
  • buildroot-external/configs/tinker_defconfig (1 hunks)
  • buildroot-external/meta (1 hunks)
✅ Files skipped from review due to trivial changes (11)
  • buildroot-external/meta
  • buildroot-external/configs/odroid_m1s_defconfig
  • buildroot-external/configs/tinker_defconfig
  • buildroot-external/configs/ova_defconfig
  • buildroot-external/configs/odroid_xu4_defconfig
  • buildroot-external/configs/odroid_n2_defconfig
  • buildroot-external/configs/generic_aarch64_defconfig
  • buildroot-external/configs/odroid_c2_defconfig
  • buildroot-external/configs/khadas_vim3_defconfig
  • buildroot-external/configs/green_defconfig
  • Documentation/kernel.md
🔇 Additional comments (9)
buildroot-external/board/raspberrypi/yellow/patches/linux/0018-ARM-dts-bcm2712-yellow-Disable-SD-SDIO-modes-on-eMMC.patch (2)

10-17: Well-documented patch with clear problem statement and impact.

The patch description effectively communicates:

  • The specific issue (eMMC initialization timeouts)
  • The quantified impact (10s per command, 130s total)
  • The improvement (100s reduction)
  • Safety considerations

32-40: Clean and focused device tree modification.

The implementation:

  • Uses standard device tree properties (no-sdio, no-sd)
  • Maintains eMMC functionality while only disabling unused modes
  • Includes clear documentation in the device tree
buildroot-external/board/raspberrypi/yellow/patches/linux/0019-ARM-dts-bcm2712-yellow-Disable-CQE-on-eMMC-interface.patch (2)

9-32: Comprehensive documentation with evidence of the issue.

The patch description effectively demonstrates the problem with:

  • Detailed system logs showing multiple blocked tasks
  • Context about similar issues with SD cards
  • Clear correlation between CQE and the hangs

43-49: Simple and effective solution to I/O hangs.

The change:

  • Takes a conservative approach by removing CQE support
  • Maintains other eMMC features (HS400, enhanced strobe)
  • Aligns with known issues in SD card implementations
buildroot-external/configs/odroid_c4_defconfig (1)

19-19: Kernel version update to 6.6.63.

The change is part of a broader kernel update across multiple platform configurations.

✅ Verification successful

Kernel version 6.6.63 is consistently set across all platform configurations

The verification confirms that all platform configuration files in buildroot-external/configs/ have been updated to use Linux kernel version 6.6.63, maintaining consistency across the entire codebase.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Verify kernel version consistency across all config files
echo "Checking kernel version consistency..."
rg "BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE=" buildroot-external/configs/

Length of output: 1288

buildroot-external/configs/odroid_m1_defconfig (1)

19-19: Verify kernel version update.

The kernel version update from 6.6.62 to 6.6.63 aligns with the PR objectives.

Let's verify this is the latest stable version in the 6.6.x series:

✅ Verification successful

Kernel version 6.6.63 is confirmed as the latest stable version in the 6.6.x series

The verification confirms that the kernel version update to 6.6.63 in the defconfig file matches the latest stable release in the 6.6.x series according to kernel.org.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check latest stable kernel version in 6.6.x series
curl -s https://www.kernel.org/releases.json | jq -r '.releases[] | select(.version | startswith("6.6.")) | .version' | sort -V | tail -n1

Length of output: 147

buildroot-external/configs/generic_x86_64_defconfig (1)

19-19: LGTM: Consistent kernel version update.

The kernel version update to 6.6.63 is consistent with other configuration files and aligns with the PR objectives.

.github/workflows/build.yaml (2)

Line range hint 1-400: LGTM: Well-structured workflow with proper conditionals.

The workflow effectively handles:

  • Different build scenarios (release vs. development)
  • Proper artifact management
  • Clear separation between build, test, and deployment stages

147-147: Verify docker/build-push-action update.

The update from v6.9.0 to v6.10.0 needs verification for any breaking changes or security fixes.

Let's check the changelog:

✅ Verification successful

Update to docker/[email protected] is safe to proceed

The changelog shows no breaking changes. The update includes:

  • A new optional call input parameter for build evaluation method
  • Dependencies security updates (@actions/core, @docker/actions-toolkit, cross-spawn)
  • All changes are backward compatible
🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check changelog for docker/build-push-action
gh api repos/docker/build-push-action/releases/tags/v6.10.0 --jq '.body'

Length of output: 598


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@sairon sairon merged commit 2f49a83 into rc Dec 2, 2024
3 checks passed
@sairon sairon deleted the prepare-14.0.rc3 branch December 2, 2024 20:11
@sairon sairon restored the prepare-14.0.rc3 branch December 2, 2024 20:20
@sairon sairon mentioned this pull request Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants