Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch 1 #6873

Closed
wants to merge 51 commits into from
Closed

Patch 1 #6873

wants to merge 51 commits into from

Conversation

arraylabs
Copy link
Contributor

@arraylabs arraylabs commented Oct 16, 2018

Description:
add info for scan_interval

Pull request in home-assistant (if applicable): home-assistant/core#17535

Checklist:

  • Branch: next is for changes and new documentation that will go public with the next home-assistant release. Fixes, changes and adjustments for the current release should be created against current.
  • [X ] The documentation follow the standards.

scop and others added 30 commits October 14, 2018 10:10
line 32: username has an - which should not be there. There is only one component: Evohome. So username and password and location_idx should be two spaces backwards. As requested. 
This has been tested by me.
* Update ifttt.markdown

* Update ifttt.markdown
Updates Vizio configuration variables to new style, as per home-assistant#6385.
* Update sensor.google_wifi.markdown

* Minor changes
* Update Sharp Aquos TV configuration to new style

Updates Sharp Aquos TV configuration variables to new style, as per home-assistant#6385.

* Remove default desc from Sharp Aquos configuration

Removed mention of defaults from the description in configuration variables since default variable is listed.

* Change power_on_enabled config variable type to boolean

Changed power_on_enabled configuration variable type to boolean from string.
* Update media player iTunes

* Minor changes
* Update media player Livebox Play TV

* Minor changes
* Update media player Anthem av

* port description update
* Update Lutron configuration to new style

Update the Lutron Configuration Variables section to the new style

Ref: home-assistant#6385

* Update lutron.markdown

Removed default from username.
Remove optional items from the "add this to `configuration.yaml`" configuration.
Add example configuration with longitude and latitude. (Taken from old configuration example.)
Add example configuration with city, state, and country. (Taken from old configuration example.)
fabaff and others added 18 commits October 16, 2018 08:50
…#6836)

* Update Telnet switch component configuration variable

* Minor changes
* Update google_assistant.markdown

Needed to make this change, as without this change, HA was giving errors pertaining to Bearer tokens, as Legacy Password was removed from my configuration

* Update google_assistant.markdown
* Update Yandextts component configuration variable

* Minor changes
…6833)

* Update Voicerss tts component configuration variable

* Minor changes
* Fix configuration variable format

Fix configuration variable format.
Modify example configuration.yaml snippet to be generic.

* Change description wording to be more clear.

Change description of 'name' to be clearer what the notifier name will be.
…stant#6851)

* Update Radiotherm climate component configuration variable

* Fix
* Update media player Channels

* Minor change
* Update media player Bluesound

* Minor changes
* Update Nest component configuration variable

* Minor changes
@fabaff
Copy link
Member

fabaff commented Oct 16, 2018

You need to rebase your branch.

@ludeeus
Copy link
Member

ludeeus commented Oct 16, 2018

@tjorim
Copy link
Contributor

tjorim commented Oct 16, 2018

scan_interval is a general entity option and shouldn't be added to this page, if I'm not mistaken. https://www.home-assistant.io/docs/configuration/platform_options/

Edit: why doesn't GitHub show it when someone else is already commenting 🙈

@arraylabs
Copy link
Contributor Author

@ludeeus @tjorim no problem, I thought I would add it as I'm not sure users are aware that it's available for most components. I honestly didn't realize it was available until I really starting digging around in the docs. I can close the request if that's best. Thanks!

@tjorim
Copy link
Contributor

tjorim commented Oct 16, 2018

I do realize that and agree the scan_interval option isn't clear to most users.
It took me some time to figure out it existed as well.

In my opinion it doesn't belong in the 'Advanced Configuration' section,
all tucked away down there.

@fabaff
Copy link
Member

fabaff commented Oct 17, 2018

The reason that scan_interval is in the advance section is that the developers of the platform or integration were taking care that API limits are not exceeded in a standard use case and resources not wasted. There are cases were we need to have that options but the regular users should not have any need to change it. Especially as most of the time the interval is decreased between the updates and not increased.

@fabaff fabaff closed this Oct 17, 2018
@ghost ghost removed the to-do label Oct 17, 2018
@fabaff fabaff added the Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! label Oct 17, 2018
@frenck frenck added the Invalid label Oct 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! Invalid
Projects
None yet
Development

Successfully merging this pull request may close these issues.