MyQ updates, scan_interval, status retries

[arraylabs]

Description:

• default SCAN_INTERVAL defined as 120 seconds not the standard 15 seconds
• SCAN_INTERVAL (the default of 120 seconds) can be overridden in configuration.yaml with scan_interval on the component
• Switch to 0.0.16 of the pymyq library which includes an endpoint change for get_status, its a more direct endpoint and the return is much smaller. Also retries 3 times for status update if server returns an error.
• change init to check door status immediately and if fails fall back to None, better than waiting for the update to get the status after HA start/restart
• Updates to close_cover and open_cover based on @ehendrix23 code with additional status check. Does two things, retries sending the open/close command if it initially fails the API call. Once API is successful it queries status until it gets an open or close status or fails. Provides a quicker update of confirmed open/close than waiting for update to occur.
• Change to update to check for False from pymyq and return either current status or None.

Related issue (if applicable): fixes #17301 #16244 #16078 #9193(maybe)

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#6873

Example entry for configuration.yaml (if applicable):

cover:
  - platform: myq
    username: !secret myq_username
    password: !secret myq_password
    type: chamberlain
    scan_interval: 300

Checklist:

• The code change is tested and works locally.
• Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated in home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• New dependencies have been added to the REQUIREMENTS variable (example).
• New dependencies are only imported inside functions that use them (example).
• New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
• New files were added to .coveragerc.

If the code does not interact with devices:

• Tests have been added to verify that the new code works.

[MartinHjelmare]

Remove this and instead call add_entities with second argument True. It will make sure update is called during entity addition.

Also, this would have made two requests to get the same status. That seems inefficient.

[MartinHjelmare]

Sleep is not allowed in our thread pool.

[MartinHjelmare]

This case is already handled in is_closed.

[MartinHjelmare]

There is also usage of sleep in the pymyq library. That isn't allowed either while using the home assistant thread pool. If you need to sleep either run a separate thread or move to asyncio.

[arraylabs]

@MartinHjelmare Thanks for the feedback! I will get the items requested changed. I didn't like the use of sleep myself and will look into changing things to asyncio (haven't used it before) as that appears the best path. I did just find information in the developer docs so I will get going through those. I'm not really a python programmer so I'm feeling some of this out along on the way.

[bachya]

@arraylabs I'm a MyQ owner and am well-versed in asyncio; happy to submit a PR to pymyq (or, if you'd rather do it, I'm at your disposal for help, questions, etc.). 👍

[arraylabs]

@bachya I would welcome a PR or any help you could provide. I've only had a chance to glance over the asyncio docs on the dev site but haven't been able to dig into them yet.

[bachya]

You got it! I’ll be in touch soon.

[bachya]

@arraylabs I've submitted a PR to turn your library to async: arraylabs/pymyq#11 – I've also included suggestions for how to proceed with this PR. Let me know!

[balloob]

This PR seems to have gone stale. Closing it.