Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use bluetooth address instead of uuid on MacOS #89926

Merged
merged 3 commits into from
Mar 20, 2023
Merged

Use bluetooth address instead of uuid on MacOS #89926

merged 3 commits into from
Mar 20, 2023

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Mar 18, 2023 •
edited
Loading

needs #89925

Breaking change

This change only affects Home Assistant instances running directly on MacOS and not inside a virtual machine.

Any integration or device that was previously set up using a UUID bluetooth address will need to be deleted and recreated

Proposed change

Bleak 0.20 added support for fetching the mac address instead of the UUID of a bluetooth device.

This allows Home Assistant instances running directly on MacOS to co-exist with bluetooth proxies and remote adapters.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@bdraco
Use bluetooth address instead of uuid on MacOS
d920db3 
Bleak 0.20 added support for fetching the mac address instead
of the UUID of a bluetooth device. This allows MacOS to nicely
co-exist with bluetooth proxies and remote adapters.

Any integration or device that was previously set up using
a UUID address will need to be deleted and recreated
@bdraco bdraco marked this pull request as ready for review March 18, 2023 22:35
@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Mar 20, 2023
frenck
frenck approved these changes Mar 20, 2023
View reviewed changes
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @bdraco 👍

../Frenck

@frenck frenck merged commit 146a311 into dev Mar 20, 2023
@frenck frenck deleted the macos_bdaddr branch March 20, 2023 11:07
@bdraco
Copy link
Member Author

bdraco commented Mar 20, 2023

thanks

@github-actions github-actions bot locked and limited conversation to collaborators Mar 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@frenck frenck frenck approved these changes

Assignees
No one assigned
Labels
breaking-change by-code-owner cla-signed integration: bluetooth Quality Scale: internal small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bdraco @frenck