Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump bluetooth deps for bleak 0.20 #89925

Merged
merged 16 commits into from
Mar 20, 2023
Merged

Bump bluetooth deps for bleak 0.20 #89925

merged 16 commits into from
Mar 20, 2023

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Mar 18, 2023

Proposed change

Bumps dependencies:

originally opened by @kiwiz in #89906 (thank you!). Since the work to support 0.20.0 turned out to be substantial I picked this up to finish it.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@bdraco

This comment was marked as outdated.

@bdraco

This comment was marked as outdated.

@bdraco bdraco changed the title Bump bleak and dbus-fast versions Bump bluetooth deps for bleak 0.20 Mar 18, 2023
@bdraco
Copy link
Member Author

bdraco commented Mar 18, 2023

@kiwiz I think this should be good to go now if you want to try it out

@bdraco
Copy link
Member Author

bdraco commented Mar 18, 2023

looks like there is another one

Mar 18 22:10:06 homeassistant homeassistant[484]: /usr/local/lib/python3.10/site-packages/bluetooth_adapters/history.py:36: FutureWarning: BLEDevice.rssi is deprecated and will be removed in a future version of Bleak, use AdvertisementData.rssi instead

@bdraco
Copy link
Member Author

bdraco commented Mar 18, 2023

manual testing is good.

Just need the CI to pass now

@bdraco bdraco marked this pull request as ready for review March 18, 2023 23:04
@bdraco bdraco requested review from Jc2k and Ernst79 as code owners March 18, 2023 23:04
@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Mar 20, 2023
@frenck frenck merged commit c3043fb into dev Mar 20, 2023
@frenck frenck deleted the bleak_bump_20 branch March 20, 2023 11:06
@bdraco
Copy link
Member Author

bdraco commented Mar 20, 2023

thanks

@github-actions github-actions bot locked and limited conversation to collaborators Mar 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed core has-tests smash Indicator this PR is close to finish for merging or closing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants